From: "Florian Köberle" <FloriansKarten@web.de>
To: git@vger.kernel.org
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
Robin Rosenberg <robin.rosenberg@dewire.com>,
Marek Zawirski <marek.zawirski@gmail.com>
Subject: Code Formatting vs Trailing Whitespaces
Date: Mon, 23 Jun 2008 20:15:50 +0200 [thread overview]
Message-ID: <485FE856.1080808@web.de> (raw)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi
I noticed that Robin removed trailing whitespaces from my patch(thanks).
It appears that if you enable code formatting and the removement of
trailing whitespaces in the save actions option that the formatting
option will win.
It will add a space at the second line of a javadoc comment:
/**
~ * <----
I think this is a bug in eclipse, did any of you create a bug report for
that? Or a feature request for an "no whitespace after javadoc" option
in the code formatter page?
I want to have both options active, because I don't want to commit wrong
formatted patches.
Best regards,
Florian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFIX+hW59ca4mzhfxMRApU4AKCbYzwRFqVcBCr11zc9lk6jqick2ACeMBhW
nXOoN4nIsTjzWWhQzDOxiz4=
=bm+i
-----END PGP SIGNATURE-----
next reply other threads:[~2008-06-23 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 18:15 Florian Köberle [this message]
2008-06-23 20:31 ` Code Formatting vs Trailing Whitespaces Robin Rosenberg
2008-06-23 21:17 ` Florian Köberle
2008-06-24 6:01 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485FE856.1080808@web.de \
--to=florianskarten@web.de \
--cc=git@vger.kernel.org \
--cc=marek.zawirski@gmail.com \
--cc=robin.rosenberg@dewire.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).