From: Thiago Farina <tfransosi@gmail.com>
To: git@vger.kernel.org
Cc: johan@herland.net
Subject: [PATCH] builtin: make commit_notes function private to notes.c
Date: Wed, 3 Nov 2010 02:47:24 -0200 [thread overview]
Message-ID: <48613a1a105a7dc6ed1fa76ac3cdae2ed2a859e4.1288759498.git.tfransosi@gmail.com> (raw)
This function was exported in builtin.h but is only used on notes.c.
Signed-off-by: Thiago Farina <tfransosi@gmail.com>
---
builtin.h | 1 -
builtin/notes.c | 2 +-
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/builtin.h b/builtin.h
index f2a25a0..8017ade 100644
--- a/builtin.h
+++ b/builtin.h
@@ -16,7 +16,6 @@ extern const char git_more_info_string[];
extern void prune_packed_objects(int);
extern int fmt_merge_msg(struct strbuf *in, struct strbuf *out,
int merge_title, int shortlog_len);
-extern int commit_notes(struct notes_tree *t, const char *msg);
struct notes_rewrite_cfg {
struct notes_tree **trees;
diff --git a/builtin/notes.c b/builtin/notes.c
index 6d07aac..89fe169 100644
--- a/builtin/notes.c
+++ b/builtin/notes.c
@@ -271,7 +271,7 @@ static int parse_reedit_arg(const struct option *opt, const char *arg, int unset
return parse_reuse_arg(opt, arg, unset);
}
-int commit_notes(struct notes_tree *t, const char *msg)
+static int commit_notes(struct notes_tree *t, const char *msg)
{
struct commit_list *parent;
unsigned char tree_sha1[20], prev_commit[20], new_commit[20];
--
1.7.3.2.90.gd4c43
reply other threads:[~2010-11-03 5:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48613a1a105a7dc6ed1fa76ac3cdae2ed2a859e4.1288759498.git.tfransosi@gmail.com \
--to=tfransosi@gmail.com \
--cc=git@vger.kernel.org \
--cc=johan@herland.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).