git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Abhijit Menon-Sen <ams@toroid.org>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] git-gui: Don't select the wrong file if the last listed file is staged.
Date: Wed, 25 Jun 2008 12:49:10 +0200	[thread overview]
Message-ID: <486222A6.70205@viscovery.net> (raw)
In-Reply-To: <20080625103650.GA20492@toroid.org>

Abhijit Menon-Sen schrieb:
> Johannes Sixt noticed that if the last file in the list was staged, my
> earlier patch would display the diff for the penultimate file, but show
> the file _before_ that as being selected.
> 
> This was due to my misunderstanding the lno argument to show_diff.
> 
> This patch fixes the problem: lno is not decremented in the special case
> to handle the last item in the list (though we still need to use $lno-1
> to find the right path for the next diff).

Thanks. It works here, too:

Tested-by: Johannes Sixt <johannes.sixt@telecom.at>

-- Hannes

  reply	other threads:[~2008-06-25 10:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12 22:12 [PATCH] git-gui: Move on to the next filename after staging/unstaging a change Abhijit Menon-Sen
2008-06-25 10:36 ` [PATCH] git-gui: Don't select the wrong file if the last listed file is staged Abhijit Menon-Sen
2008-06-25 10:49   ` Johannes Sixt [this message]
2008-06-25 20:57     ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=486222A6.70205@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=ams@toroid.org \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).