From: "H. Peter Anvin" <hpa@zytor.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] Teach "git apply" to prepend a prefix with "--root=<root>"
Date: Tue, 01 Jul 2008 09:05:04 -0700 [thread overview]
Message-ID: <486A55B0.9050404@zytor.com> (raw)
In-Reply-To: <7vvdzqnemk.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
>
> The -p<num> came from patch where it is also called --strip=num. This new
> option --root is about the reverse operation and it is about inserting at
> the beginning --- it is rerooting, in other words, but then --root is good
> enough and shorter. mkisofs uses the word "graft" when it allows tree
> shifting (enabled with --graft-points), but the word "graft" means a
> totally different thing to us, so we would not want to use that word.
>
> I am not complaining (--root is fine by me), but just thinking aloud,
> hoping somebody's brainwave is provoked while reading this babbling and
> comes up with a better wording ;-).
>
There is an analogous concept in patch(1), it's just implemented by
cd'ing to a subdirectory first. ;)
I think --root makes sense as the root of the patch. The other
alternative would be --add (by analogy with --strip); the biggest
advantage there is that -a, as a short option, isn't used for anything
either by git-am, git-apply, or patch.
Incidentally, has anyone talked to the patch(1) maintainers about adding
support for the git extensions, like binary patches? The main reason is
that patch(1) is still useful when you have to suffer though fuzzy errors.
-hpa
next prev parent reply other threads:[~2008-07-01 16:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 23:44 [PATCH] Teach "git apply" to prepend a prefix with "--root=<root>" Johannes Schindelin
2008-07-01 9:21 ` Junio C Hamano
2008-07-01 16:05 ` H. Peter Anvin [this message]
2008-07-01 16:36 ` Johannes Schindelin
2008-07-01 16:57 ` H. Peter Anvin
2008-07-01 18:10 ` Raimund Bauer
2008-07-01 20:27 ` H. Peter Anvin
2008-07-01 16:34 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486A55B0.9050404@zytor.com \
--to=hpa@zytor.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox