From: Mark Levedahl <mlevedahl@gmail.com>
To: Sylvain Joyeux <sylvain.joyeux@dfki.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Lars Hjemli <hjemli@gmail.com>, Ping Yin <pkufranky@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] fix "git-submodule add a/b/c/repository"
Date: Mon, 07 Jul 2008 22:23:02 -0400 [thread overview]
Message-ID: <4872CF86.5050702@gmail.com> (raw)
In-Reply-To: <20080707063424.GB5506@jhaampe.org>
Sylvain Joyeux wrote:
>
> Redo the prep work, the clone and now
>
> git submodule add dir0/dir1/init
>
> (i.e. don't expect dir0/dir1/init to be the clone of ./init, that was just a
> shortcut for the test. Expect it to be a clone of "something, somewhere")
>
>
Per the man-page,
git submodule [--quiet] add [-b branch] [--] <repository> [<path>]
which means, that the *repository* url is mandatory, the path is
optional. What you specifically asked git-submodule to do was to *clone*
from dir0/dir1/init, and because you gave no path to put the submodule
in, git-submodule deduced the name as "init", and cloned to there.
Mark
next prev parent reply other threads:[~2008-07-08 2:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 15:00 [PATCH] fix "git-submodule add a/b/c/repository" Sylvain Joyeux
2008-07-06 6:27 ` Junio C Hamano
2008-07-06 16:11 ` Sylvain Joyeux
2008-07-06 19:05 ` Mark Levedahl
2008-07-07 6:34 ` Sylvain Joyeux
2008-07-08 2:23 ` Mark Levedahl [this message]
2008-07-08 2:42 ` Junio C Hamano
2008-07-08 3:26 ` Mark Levedahl
2008-07-08 6:02 ` Junio C Hamano
2008-07-08 23:57 ` Mark Levedahl
2008-07-09 3:59 ` [PATCH] git-submodule - make "submodule add" more strict, and document it Mark Levedahl
2008-07-09 6:04 ` Junio C Hamano
2008-07-10 1:05 ` Mark Levedahl
2008-07-10 1:05 ` [PATCH] git-submodule - register submodule URL if adding in place Mark Levedahl
2008-07-08 8:08 ` [PATCH] fix "git-submodule add a/b/c/repository" Sylvain Joyeux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4872CF86.5050702@gmail.com \
--to=mlevedahl@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hjemli@gmail.com \
--cc=pkufranky@gmail.com \
--cc=sylvain.joyeux@dfki.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).