From: Johannes Sixt <j.sixt@viscovery.net>
To: Pierre Habouzit <madcoder@debian.org>
Cc: git@vger.kernel.org, torvalds@linux-foundation.org,
gitster@pobox.com, peff@peff.net
Subject: Re: [PATCH 2/6] revisions: split the pure option parsing out from parse_revisions.
Date: Tue, 08 Jul 2008 12:51:13 +0200 [thread overview]
Message-ID: <487346A1.4040006@viscovery.net> (raw)
In-Reply-To: <1215510964-16664-3-git-send-email-madcoder@debian.org>
Pierre Habouzit schrieb:
> +int handle_revision_opt(struct rev_info *revs, int argc, const char **argv,
> + int *unkc, const char **unkv)
> +{
> + const char *arg = argv[0];
> +
> + /* pseudo revision arguments */
> + if (!strcmp(arg, "--all") || !strcmp(arg, "--branches") ||
> + !strcmp(arg, "--tags") || !strcmp(arg, "--remotes") ||
> + !strcmp(arg, "--reflog") || !strcmp(arg, "--not") ||
> + !strcmp(arg, "--no-walk") || !strcmp(arg, "--do-walk"))
> + {
> + unkv[*unkc++] = arg;
+ unkv[(*unkc)++] = arg;
Hm?
-- Hannes
next prev parent reply other threads:[~2008-07-08 10:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 9:55 Migration of builtin-blame to parse-option Pierre Habouzit
2008-07-08 9:55 ` [PATCH 1/6] revisions: refactor init_revisions and setup_revisions Pierre Habouzit
2008-07-08 9:56 ` [PATCH 2/6] revisions: split the pure option parsing out from parse_revisions Pierre Habouzit
2008-07-08 9:56 ` [PATCH 3/6] revisions: parse_revisions refactor Pierre Habouzit
2008-07-08 9:56 ` [PATCH 4/6] revisions: split handle_revision_args from parse_revisions Pierre Habouzit
2008-07-08 9:56 ` [PATCH 5/6] git-blame: migrate to incremental parse-option [1/2] Pierre Habouzit
2008-07-08 9:56 ` [PATCH 6/6] git-blame: migrate to incremental parse-option [2/2] Pierre Habouzit
2008-07-08 10:51 ` Johannes Sixt [this message]
2008-07-08 11:00 ` [PATCH 2/6] revisions: split the pure option parsing out from parse_revisions Pierre Habouzit
2008-07-08 11:25 ` Pierre Habouzit
2008-07-08 10:59 ` [PATCH 1/6] revisions: refactor init_revisions and setup_revisions Johannes Schindelin
2008-07-08 11:06 ` Pierre Habouzit
2008-07-08 11:43 ` Johannes Schindelin
2008-07-08 12:48 ` Pierre Habouzit
2008-07-08 10:02 ` Migration of builtin-blame to parse-option Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487346A1.4040006@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
--cc=peff@peff.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).