git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Ericsson <ae@op5.se>
To: Sylvain Joyeux <sylvain.joyeux@dfki.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] better git-submodule status output
Date: Wed, 09 Jul 2008 12:25:25 +0200	[thread overview]
Message-ID: <48749215.6070307@op5.se> (raw)
In-Reply-To: <20080709101330.GA3525@joyeux>

Sylvain Joyeux wrote:
> Here is a (tentative) summary of the whole discussion:
> 
> * doing fetch in status is EVIL. Therefore, status should only report
>   whatever information is available.
> * nonetheless, having a "peek" mode seem to be accepted as a useful
>   feature not only by me.
> * changing the output format of git-submodules is not right either,
>   because it would break existing tools which parses it at the moment.
> 
> Proposal
> - remove fetch from status, and make the new output enabled when
>   --verbose is set (can also be set in the config file I guess).
> 
>   On the symbols side, I propose:
>     > submodule commit is a direct descendant of the commit in the
>       superproject
>     < submodule commit is a direct ancestor of the commit in the
>       superproject
>     + no direct relation between submodule commit and commit in the
>       superproject
>     ? the commit in the superproject cannot be found in the submodule
>       (replaces the initial '!' in my patch)
> 
>   A 'M' is appended if the submodule has uncommitted changes
> 
> - define a git-submodule 'fetch' subcommand which call fetch in each
>   submodule and runs the verbose mode of git-status (can be disabled by
>   a --quiet option).
> 
> Comments ? (I'm sure there are some ...)
> 

Re-use the existing symbolism from fetch status output. Using '+' to
denote "no direct relation" in a tool that shows patches half the
time is just plain horrible.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

  reply	other threads:[~2008-07-09 10:29 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-01 15:01 [PATCH] better git-submodule status output Sylvain Joyeux
2008-07-06  6:19 ` Junio C Hamano
2008-07-06 12:57   ` Johannes Schindelin
2008-07-06 16:07     ` Sylvain Joyeux
2008-07-06 16:29       ` Johannes Schindelin
2008-07-07  6:21         ` Sylvain Joyeux
2008-07-07 14:25           ` Avery Pennarun
2008-07-07 14:34             ` Johannes Schindelin
2008-07-07 14:37               ` Johannes Schindelin
2008-07-07 14:57                 ` Sylvain Joyeux
2008-07-07 15:21                   ` Johannes Schindelin
2008-07-07 15:42                     ` Sylvain Joyeux
2008-07-07 18:20                   ` Junio C Hamano
2008-07-07 18:29                     ` Avery Pennarun
2008-07-07 19:51                       ` Junio C Hamano
2008-07-08  8:00                     ` Sylvain Joyeux
2008-07-08 11:21                       ` Johannes Schindelin
2008-07-08 12:22                         ` Sylvain Joyeux
2008-07-08 13:00                           ` Johannes Schindelin
2008-07-08 13:12                             ` Sylvain Joyeux
2008-07-07 14:57               ` Avery Pennarun
2008-07-07 15:23                 ` Johannes Schindelin
2008-07-07 15:36                   ` Avery Pennarun
2008-07-07 16:10                     ` Johannes Schindelin
2008-07-07 15:52                   ` Sylvain Joyeux
2008-07-07 15:00             ` Sylvain Joyeux
2008-07-06 13:14   ` Mark Levedahl
2008-07-09 10:13 ` Sylvain Joyeux
2008-07-09 10:25   ` Andreas Ericsson [this message]
2008-07-09 11:01     ` Sylvain Joyeux
2008-07-09 12:31   ` Johannes Schindelin
2008-07-09 13:46     ` Sylvain Joyeux
2008-07-09 13:54       ` Johannes Schindelin
2008-07-09 18:48   ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2008-07-01 14:57 Sylvain Joyeux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48749215.6070307@op5.se \
    --to=ae@op5.se \
    --cc=git@vger.kernel.org \
    --cc=sylvain.joyeux@dfki.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).