From: SungHyun Nam <namsh@posdata.co.kr>
To: git@vger.kernel.org
Subject: Re: git-remote SEGV on t5505 test.
Date: Fri, 18 Jul 2008 14:44:45 +0900 [thread overview]
Message-ID: <48802DCD.2090704@posdata.co.kr> (raw)
In-Reply-To: <7vsku7es3n.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> SungHyun Nam <namsh@posdata.co.kr> writes:
>
>> And the 'skip_prefix()' returns NULL in this case.
>> (The old skip_prefix() never returns NULL).
>
> Thanks. Something like this?
With this patch, 'make test' passed all the tests successfully.
I ran test with GIT_SKIP_TESTS="t90?? t91?? t92?? t94??".
Regards,
namsh
P.S I skipped svn/cvs test because I don't need them (And no
svn/cvs installed). But, I skipped send-email test because it
fails. I thought I don't need to use send-email.
And now I check what caused fail. The problem was this test
script generates 'fake.sendmail' which uses '/bin/sh'.
Is it possible that we can use 'SHELL_PATH' here? Or could
you apply the patch below?
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index de5b980..0320aa1 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -16,7 +16,7 @@ test_expect_success \
'(echo "#!/bin/sh"
echo shift
echo output=1
- echo "while test -f commandline\$output; do
output=\$((\$output+1)); done"
+ echo "while test -f commandline\$output; do output=\`expr
\$output + 1\`; done"
echo for a
echo do
echo " echo \"!\$a!\""
next prev parent reply other threads:[~2008-07-18 5:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 1:46 git-remote SEGV on t5505 test SungHyun Nam
2008-07-18 4:25 ` Junio C Hamano
2008-07-18 5:44 ` SungHyun Nam [this message]
2008-07-18 6:18 ` Re* " Junio C Hamano
2008-07-18 6:26 ` Junio C Hamano
2008-07-18 9:07 ` SungHyun Nam
2008-07-18 9:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48802DCD.2090704@posdata.co.kr \
--to=namsh@posdata.co.kr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).