git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Aurel <ben.aurel@gmail.com>
To: git@vger.kernel.org
Subject: Error: "You have some suspicious patch lines"
Date: Tue, 22 Jul 2008 09:16:44 +0200	[thread overview]
Message-ID: <4885895C.5050108@gmail.com> (raw)

hi

I working on mac os x 10.5.4 (intel) with git version 1.5.5.3 and I 
always get this message for most of my perl scripts and also for 
"Makefile.pre" files:

----------- Message ---------------
* You have some suspicious patch lines:
*
* In src/scripts/trunk/3rdparty/file_sanity.pl
* trailing whitespace (line 52)
...
------------------------------------------


Editing '.git/hooks/pre-commit' and comment out the following lines 
(around line 58):

--
58            if (/\s$/) {
59                bad_line("trailing whitespace", $_);
60             }
--

I still have this message

----------- Message ---------------
$ git commit .
*
* You have some suspicious patch lines:
*
* In src/scripts/trunk/3rdparty/file_sanity.pl
* indent SP followed by a TAB (line 112)
-----------------------------------------

Editing '.git/hooks/pre-commit' and comment out the following lines
--
 61             if (/^\s* \t/) {
 62                 bad_line("indent SP followed by a TAB", $_);
 63             }
--

And finally "git commit" works again.

The question now is: Is it really necessary to edit the git script 
everytime? Is there a urgent reason why git refuses to commit because of 
"suspicious" lines? Is it really necessary?

Thanks
ben

             reply	other threads:[~2008-07-22  7:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-22  7:16 Ben Aurel [this message]
2008-07-22  7:26 ` Error: "You have some suspicious patch lines" Jeff King
2008-07-22  9:13 ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4885895C.5050108@gmail.com \
    --to=ben.aurel@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).