git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Haslam <shaslam@lastminute.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Remove references to git-fetch-pack from "git clone" documentation.
Date: Mon, 28 Jul 2008 13:32:50 +0100	[thread overview]
Message-ID: <488DBC72.8040204@lastminute.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0807260523520.26810@eeepc-johanness>

Johannes Schindelin wrote:
> Hi,
>
> On Fri, 25 Jul 2008, Steve Haslam wrote
>> "git clone" no longer calls "git-fetch-pack",
>>     
>
> So it calls it internally, avoiding fork() and exec().  But the code is 
> still git-fetch-pack's.  The difference should be lost on the regular Git 
> user.
>   
Well, I would say that the git-clone command uses code that is also used 
by the git-fetch-pack command; but as you indicate, this is a minor 
implementation detail.

I think that the documentation was perhaps too explicit and as a result 
stale: git-clone certainly does not work any more by creating a 
"--exec=..." argument to pass to the git-fetch-pack command even 
internally, it calls code in transport.c. As you say, the difference is 
immaterial to most users, and a simplified version of the documentation 
should be adequate (and possibly clearer).

SRH

  reply	other threads:[~2008-07-28 12:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-25 18:37 [PATCH] Remove references to git-fetch-pack from "git clone" documentation Steve Haslam
2008-07-26  3:24 ` Johannes Schindelin
2008-07-28 12:32   ` Steve Haslam [this message]
2008-07-28 12:41     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=488DBC72.8040204@lastminute.com \
    --to=shaslam@lastminute.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).