git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pascal Obry <pascal@obry.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git list <git@vger.kernel.org>
Subject: Re: git svn and the post-receive hook
Date: Sat, 02 Aug 2008 21:20:39 +0200	[thread overview]
Message-ID: <4894B387.4040004@obry.net> (raw)
In-Reply-To: <7vwsizl0l9.fsf@gitster.siamese.dyndns.org>


Junio,

> Are you saying that there may be breakages that is made at the Subversion
> side, and you would want to catch it?

Exactly.

> What would you do _after_ finding out that somebody screwed up and you
> have a borked history on the Subversion side already?

Notify the developer(s) about the problem(s).

> I do not think this belongs to "git svn rebase" (let alone "git rebase",
> no way --- you won't rewrite nor reject the upstream even if you find
> problems with it).
> 
> I understand that you would at least want to notice the damange to the
> history that happened at the remote end, and I agree it would make sense
> to do something like:
> 
> 	$ git command-that-updates-the-remote-tracking-branch git-svn
>         $ check-history git-svn@{1}..git-svn
> 
> The "command-that-updates" could be "svn fetch" or just a simple "fetch".
> 
> But the "check-history" script will be very specific to your project, and
> I do not think it makes sense to make it a hook to the "command-that-updates".

Hum... Any hook is very specific to a project. That's why it is a hook 
and not a built-in command.

BTW, I do not see why this would be a problem with git-svn whereas the 
post-receive hook is fine for Git. In many projects rewriting history is 
not permitted but post-receive is quite handy to do some checks.

post-received receive 3 parameters:

   - sha before
   - sha after
   - refname

It is perfectly usable after a git-svn rebase.

Pascal.

-- 

--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|              http://www.obry.net
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595

  reply	other threads:[~2008-08-02 19:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-02 16:05 git svn and the post-receive hook Pascal Obry
2008-08-02 18:03 ` Miklos Vajna
2008-08-02 18:22 ` Junio C Hamano
2008-08-02 18:43 ` Junio C Hamano
2008-08-02 19:20   ` Pascal Obry [this message]
2008-08-02 20:16     ` Junio C Hamano
2008-08-02 20:45       ` Miklos Vajna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4894B387.4040004@obry.net \
    --to=pascal@obry.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).