git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "\"Peter Valdemar Mørch (Lists)\"" <4ux6as402@sneakemail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: git@vger.kernel.org
Subject: Re: git diff/log --check exitcode and PAGER environment variable
Date: Fri, 08 Aug 2008 12:04:48 +0200	[thread overview]
Message-ID: <489C1A40.9000001@sneakemail.com> (raw)
In-Reply-To: <7vfxpfet8a.fsf@gitster.siamese.dyndns.org>

Junio C Hamano gitster-at-pobox.com |Lists| wrote:
>> There is this old thread:
>> "[PATCH 1/5] "diff --check" should affect exit status"
>> http://thread.gmane.org/gmane.comp.version-control.git/68145/focus=68148
>> which seemed not to reach a conclusion.
> 
> Conclusion was (1) if you really care about the exit code, do not use
> pager; (2) after 1.6.0 we will swap the child/parent between git and pager
> to expose exit code from us, but not before.
> 
> Or am I mistaken?

Perhaps a more correct statement on my part would have been that I 
couldn't find the conclusion. :-)

It ended with Junio C Hamano saying:
> Heh, I am about to push out fixed-up results, so it might save both of
> us some time if you looked at it first and then complained on my
> screwups.

I wasn't subscribed to the list back then and couldn't follow beyond 
that thread in GMane.

Regardless of what happened or not back then, the current documentation 
does not match the current code. Not for git-diff, and certainly not for 
git-log.

Or am I mistaken?

I didn't see a reference in that thread to post 1.6.0 changes or to 
child/parent relationships, but if this is known and planned for 
post-1.6.0, then cool: I'll get on with my life and let you get on with 
yours!

Peter
-- 
Peter Valdemar Mørch
http://www.morch.com

  reply	other threads:[~2008-08-08 10:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08  9:39 git diff/log --check exitcode and PAGER environment variable "Peter Valdemar Mørch (Lists)"
2008-08-08  9:44 ` Junio C Hamano
2008-08-08 10:04   ` "Peter Valdemar Mørch (Lists)" [this message]
2008-08-08 10:15   ` Re* " Junio C Hamano
2008-08-08 11:02     ` "Peter Valdemar Mørch (Lists)"
2008-08-08 11:23       ` Johannes Schindelin
2008-08-08 20:40         ` Junio C Hamano
2008-08-09  6:57         ` [PATCH] Teach git log --check to return an appropriate error code Peter Valdemar Mørch
2008-08-09 12:05           ` Johannes Schindelin
2008-08-09 19:29             ` Junio C Hamano
2008-08-10 17:05               ` "Peter Valdemar Mørch (Lists)"
2008-08-10 18:40                 ` Junio C Hamano
2008-08-09 18:58           ` Junio C Hamano
2008-08-11  6:46           ` PATCH v2 0/2 Trying patch again Peter Valdemar Mørch
2008-08-11  6:46             ` [PATCH v2 1/2] Teach git log --check to return an appropriate exit code Peter Valdemar Mørch
2008-08-11  6:46               ` [PATCH v2 2/2] Teach git log --exit-code " Peter Valdemar Mørch
2008-08-08 13:17   ` git diff/log --check exitcode and PAGER environment variable Jeff King
2008-08-08 13:19     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489C1A40.9000001@sneakemail.com \
    --to=4ux6as402@sneakemail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).