git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Francis Moreau <francis.moro@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git-bisect: weird usage of read(1)
Date: Mon, 11 Aug 2008 18:18:33 +0200	[thread overview]
Message-ID: <48A06659.6010004@lsrfire.ath.cx> (raw)
In-Reply-To: <38b2ab8a0808110657y24ac9526wca4acea3bddaec00@mail.gmail.com>

Francis Moreau schrieb:
> I found this in git bisect:
> 
>               printf >&2 'Are you sure [Y/n]? '
>               case "$(read yesno)" in [Nn]*) exit 1 ;; esac
> 
> which looks very weird since read(1) returns a status and not the
> string reads from std input.

Good catch.  You need to press Ctrl-C in order to exit, answering "no"
means the same as "yes" here -- not very nice.  Care to send a patch?

Thanks,
René

  parent reply	other threads:[~2008-08-11 16:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-11 13:57 git-bisect: weird usage of read(1) Francis Moreau
2008-08-11 14:15 ` Johannes Schindelin
2008-08-11 14:16   ` Mikael Magnusson
2008-08-11 14:18   ` Francis Moreau
2008-08-11 15:59     ` Reece Dunn
2008-08-11 16:23       ` Francis Moreau
2008-08-11 16:26         ` Reece Dunn
2008-08-11 16:29           ` Francis Moreau
2008-08-11 16:49       ` Petr Baudis
2008-08-11 17:01         ` René Scharfe
2008-08-11 17:05           ` Petr Baudis
2008-08-11 18:59           ` Junio C Hamano
2008-08-11 19:47             ` Francis Moreau
2008-08-11 16:18 ` René Scharfe [this message]
2008-08-11 17:38   ` Francis Moreau
  -- strict thread matches above, loose matches on Subject: below --
2008-08-11 14:00 Francis Moreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A06659.6010004@lsrfire.ath.cx \
    --to=rene.scharfe@lsrfire.ath.cx \
    --cc=francis.moro@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).