From: Johannes Sixt <j.sixt@viscovery.net>
To: Marcus Griep <marcus@griep.us>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2] count-objects: add human-readable size option
Date: Thu, 14 Aug 2008 09:39:46 +0200 [thread overview]
Message-ID: <48A3E142.9060606@viscovery.net> (raw)
In-Reply-To: <1218687684-11671-1-git-send-email-marcus@griep.us>
Marcus Griep schrieb:
> +void human_readable_size(char *buf, int buf_size, double size /* in bytes */)
> +{
> + char human_readable_prefixes[10] = "BKMGTPEZY";
> + if (buf_size < 5)
> + die("insufficient buffer size");
> + int i = 0;
> + for (; i < 8 && size >= 1000 ; ++i, size = size / 1024)
> + ;
> + if (size >= 1000)
> + die("size greater than 999Y");
No need to die here. Just make the buffer large enough, and you can have
something that is as large as 18446744073709551615Y.
-- Hannes
next prev parent reply other threads:[~2008-08-14 7:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 20:05 [PATCH] count-objects: Add total pack size to verbose output Marcus Griep
2008-08-14 4:21 ` [PATCH 2] count-objects: add human-readable size option Marcus Griep
2008-08-14 4:38 ` Shawn O. Pearce
2008-08-14 4:44 ` Marcus Griep
2008-08-14 5:22 ` Junio C Hamano
2008-08-14 14:05 ` Johannes Schindelin
2008-08-14 14:26 ` Marcus Griep
2008-08-14 6:45 ` Alex Riesen
2008-08-14 14:03 ` Marcus Griep
2008-08-14 18:51 ` Alex Riesen
2008-08-15 9:22 ` Pierre Habouzit
2008-08-18 17:28 ` Alex Riesen
2008-08-14 7:39 ` Johannes Sixt [this message]
2008-08-14 14:09 ` Marcus Griep
2008-08-14 15:14 ` Petr Baudis
2008-08-14 16:26 ` Marcus Griep
2008-08-14 16:34 ` Petr Baudis
2008-08-14 16:42 ` Marcus Griep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A3E142.9060606@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marcus@griep.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).