git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Tor Arne Vestbø" <torarnv@gmail.com>
To: git@vger.kernel.org
Cc: "s >> \"Shawn O. Pearce\"" <spearce@spearce.org>
Subject: Re: [EGIT PATCH] Fix invalid menubar and toolbar entries in plugin.xml
Date: Thu, 14 Aug 2008 23:43:20 +0200	[thread overview]
Message-ID: <48A4A6F8.3060205@gmail.com> (raw)
In-Reply-To: <200808142242.20476.robin.rosenberg.lists@dewire.com>

Robin Rosenberg wrote:
>> Either way I suggest the patch is still valid, because it removes
>> the Git menu from the menu bar. This is consistent with what other 
> But I don't want it removed... , but I can consider hiding the git actions by default.

I see now that both the CVS and SVN plugins have top level menus and toolbars 
(they are hidden by default), so I'm perfectly fine with us doing the same.

Do you want me to resubmit the patch, or is it enough with the patch you amended?

Thanks,

Tor Arne

  parent reply	other threads:[~2008-08-14 21:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-13 19:07 [PATCH] Fix invalid menubar and toolbar entries in plugin.xml Tor Arne Vestbø
2008-08-14  5:47 ` [EGIT PATCH] " Robin Rosenberg
2008-08-14 17:42   ` Robin Rosenberg
2008-08-14 19:13     ` Tor Arne Vestbø
2008-08-14 20:42       ` Robin Rosenberg
2008-08-14 20:45         ` [EGIT PATCH] Hide the Git menu and toolbars by default and fix the path of the Git menu Robin Rosenberg
2008-08-14 21:43         ` Tor Arne Vestbø [this message]
2008-08-14 22:07         ` [EGIT PATCH v2] Fix invalid menubar and toolbar entries in plugin.xml Tor Arne Vestbø

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A4A6F8.3060205@gmail.com \
    --to=torarnv@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).