From: Marcus Griep <neoeinstein@gmail.com>
To: Marco Costalba <mcostalba@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git mailing list <git@vger.kernel.org>
Subject: Re: Stange diff in "mailinfo: re-fix MIME multipart boundary parsing"
Date: Tue, 19 Aug 2008 13:51:01 -0400 [thread overview]
Message-ID: <48AB0805.1020309@gmail.com> (raw)
In-Reply-To: <e5bfff550808191038u645cf4baldca5c2c4bbd02162@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 573 bytes --]
Marco Costalba wrote:
> Looking the diff at
>
> http://git.kernel.org/?p=git/git.git;a=commitdiff;h=289796dd29dd656734cfd59b657deb943a71cf6a
>
> the part of the patch applied to /t/t5100/sample.mbox file seems very
> strange, is it correct ?
It looks like an empty line added to the end of the file.
Unsanitary, but ok since it comes after the last MIME
multipart boundary. Junio could probably just ax the change
to sample.mbox from the patch before applying it.
--
Marcus Griep
GPG Key ID: 0x5E968152
——
http://www.boohaunt.net
את.ψο´
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 793 bytes --]
next prev parent reply other threads:[~2008-08-19 17:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 17:38 Stange diff in "mailinfo: re-fix MIME multipart boundary parsing" Marco Costalba
2008-08-19 17:51 ` Marcus Griep [this message]
2008-08-19 17:57 ` Marcus Griep
2008-08-20 13:10 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AB0805.1020309@gmail.com \
--to=neoeinstein@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mcostalba@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).