git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <bonzini@gnu.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Tommi Virtanen <tv@eagain.net>,
	Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] "git shell" won't work, need "git-shell"
Date: Mon, 25 Aug 2008 13:44:42 +0200	[thread overview]
Message-ID: <48B29B2A.6000802@gnu.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0808251235430.24820@pacific.mpi-cbg.de.mpi-cbg.de>


>> At the minimum, git-shell(1) should explain that one needs to use the
>> libexec path.
> 
> Or maybe the real issue can be fixed?  Namely that your configuration does 
> not work?  That would involve you actually finding out what's happening, 
> though.

He said so:

> The shell field in /etc/passwd is *exec*ed, not interpreted via sh -c
> or some such. For example, source of Debian's shadow, containing
> /bin/login:
> 
> libmisc/shell.c:80:	execle (file, arg, (char *) 0, envp);
> 
> I also tested this for real, and having a
> 
> test:x:1001:1001:,,,:/home/test:/usr/bin/git-shell
> 
> line works, and
> 
> test:x:1001:1001:,,,:/home/test:/usr/bin/git shell
> 
> just makes ssh loop asking for a password, logging
> 
> "User test not allowed because shell /usr/bin/git shell does not exist"
> 
> So, as far as I understand, as it currently is, "git shell" is utterly
> useless for what it was meant to do. Restoring "git-shell" will fix
> it.

Rephrasing your question, do you (Dscho) actually know *anyone* who has
a working setup with "/usr/bin/git shell" in /etc/passwd?

Paolo

  reply	other threads:[~2008-08-25 11:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-24 20:23 [PATCH] "git shell" won't work, need "git-shell" Tommi Virtanen
2008-08-24 20:36 ` Junio C Hamano
2008-08-24 20:38   ` Tommi Virtanen
2008-08-24 21:20     ` Junio C Hamano
2008-08-24 22:25       ` Tommi Virtanen
2008-08-25 10:37         ` Johannes Schindelin
2008-08-25 11:44           ` Paolo Bonzini [this message]
2008-08-25 17:58             ` Johannes Schindelin
2008-08-25 18:25               ` Mikael Magnusson
2008-08-25 20:08                 ` Johannes Schindelin
2008-08-25 20:28                   ` Johannes Schindelin
2008-08-25 20:51                     ` [PATCH 1/2] git wrapper: Make while loop more reader-friendly Johannes Schindelin
2008-08-25 20:52                       ` [PATCH 2/2] git wrapper: execute git-shell when argv[1] is '-c' Johannes Schindelin
2008-08-25 21:03                         ` Tommi Virtanen
2008-08-25 22:05                           ` Johannes Schindelin
2008-08-25 22:20                             ` Tommi Virtanen
2008-08-26  0:52                               ` Johannes Schindelin
2008-08-26  6:53                                 ` Matthieu Moy
2008-08-26 17:43                                   ` Junio C Hamano
2008-08-26  8:50                       ` [PATCH 1/2] git wrapper: Make while loop more reader-friendly Mike Ralphson
2008-08-25 17:08       ` [PATCH] "git shell" won't work, need "git-shell" Petr Baudis
2008-08-25 17:20         ` Dmitry Potapov
2008-08-25 17:26           ` Tommi Virtanen
2008-08-25 17:53             ` Dmitry Potapov
2008-08-25 18:17           ` Johannes Schindelin
2008-08-25 20:26             ` Dmitry Potapov
2008-08-25 20:40             ` Mike Hommey
2008-10-28 11:11 ` Dmitry V. Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B29B2A.6000802@gnu.org \
    --to=bonzini@gnu.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=tv@eagain.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).