From: Michael J Gruber <michaeljgruber+gmane@fastmail.fm>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2] allow user aliases for the --author parameter
Date: Thu, 28 Aug 2008 10:53:23 +0200 [thread overview]
Message-ID: <48B66783.4050305@fastmail.fm> (raw)
In-Reply-To: <20080827171846.GA14300@coredump.intra.peff.net>
Jeff King venit, vidit, dixit 27.08.2008 19:18:
> On Wed, Aug 27, 2008 at 10:15:19AM -0700, Junio C Hamano wrote:
>
>>> I wonder if there is a good way to warn that we have multiple matches.
>>> Of course we expect many _exact_ matches if the author has multiple
>>> commits, but we could look for distinct matches. However, even that will
>>> turn up false positives, since some authors have multiple email
>>> addresses.
>> In order to prove unique match you would need an exhaustive check, don't
>> you?
>
> Yes, though you also do exhaustive check in the worst case already (when
> the name doesn't match anything). It takes about .7s on a warm cache on
> my git.git.
>
> Anyway, I think it is already not a good idea because of the semantics,
> let alone the performance.
By "it" you are referring to
- checking for uniqueness or
- the whole approach combing through commits?
I'd be happy with the patch as is (+"-i" maybe) now that I understand
the template... (I tried --author=key with a key expanding to the
(default) committer, in which case the commit template does not show
author nor committer. Duh.)
> -Peff
>
> PS Your message also didn't go to git@vger, so I think you are having
> the same problem with Michael's message that I am.
OK: I send this To: Jeff, Cc: Junio, Nntp:
gmane.comp.version-control.git (using Thunderbird 2). (This is the
result of hitting "reply all" and deleting git@vger, because it's
duplicated by gmane...git.)
Could the two of you please tell me what you are receiving? I'm sorry
for this, but if this is a systematic problem with gmane I should switch
(and others should be warned); if it's a TB thing I will cope.
Michael
next prev parent reply other threads:[~2008-08-28 8:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 9:19 [PATCH] allow user aliases for the --author parameter Michael J Gruber
2008-08-21 13:49 ` Miklos Vajna
2008-08-21 14:30 ` Michael J Gruber
2008-08-21 17:41 ` Alex Riesen
2008-08-21 17:49 ` Alex Riesen
2008-08-21 20:02 ` Jeff King
2008-08-22 6:09 ` Junio C Hamano
2008-08-22 8:27 ` Michael J Gruber
2008-08-22 16:50 ` Jeff King
2008-08-22 21:09 ` Junio C Hamano
2008-08-22 21:19 ` Jeff King
2008-08-26 8:02 ` [PATCH v2] " Michael J Gruber
2008-08-26 23:31 ` Junio C Hamano
2008-08-27 0:19 ` Jeff King
2008-08-27 6:13 ` Junio C Hamano
2008-08-27 9:36 ` Michael J Gruber
2008-08-27 12:40 ` Jeff King
[not found] ` <20080827123656.GB11986@coredump.intra.peff.net>
[not found] ` <7vmyiyqt08.fsf@gitster.siamese.dyndns.org>
2008-08-27 17:18 ` Jeff King
2008-08-28 8:53 ` Michael J Gruber [this message]
2008-08-28 21:33 ` Jeff King
[not found] ` <7vr68aqt3h.fsf@gitster.siamese.dyndns.org>
[not found] ` <48B65922.4050005@fastmail.fm>
2008-08-28 21:36 ` Jeff King
2008-08-27 12:29 ` Jeff King
2008-08-27 17:19 ` Junio C Hamano
2008-08-24 9:19 ` [PATCH] " Pedro Melo
2008-08-24 17:21 ` Jeff King
2008-08-25 1:38 ` [PATCH] fix "git log -i --grep" Jeff King
2008-08-25 2:10 ` [PATCH] format-patch: use default diff format even with patch options Jeff King
2008-08-25 4:57 ` Junio C Hamano
2008-08-25 5:12 ` [PATCH] fix "git log -i --grep" Junio C Hamano
2008-08-25 6:15 ` Jeff King
2008-08-25 6:18 ` Jeff King
2008-08-25 6:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B66783.4050305@fastmail.fm \
--to=michaeljgruber+gmane@fastmail.fm \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).