From: Andreas Ericsson <ae@op5.se>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, Brian Gernhardt <benji@silverinsanity.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] t6013: replace use of 'tac' with equivalent Perl
Date: Mon, 01 Sep 2008 14:56:34 +0200 [thread overview]
Message-ID: <48BBE682.2070000@op5.se> (raw)
In-Reply-To: <1220221897-6081-1-git-send-email-trast@student.ethz.ch>
Thomas Rast wrote:
> 'tac' is not available everywhere, so substitute the equivalent Perl
> code 'print reverse <>'. Noticed by Brian Gernhardt.
>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
>
> Thanks for pointing this out. However, I tried to avoid hardcoding
> those results by recommendation of t/README (last paragraph):
>
> ... If all the test scripts hardcoded the object IDs like
> t0000-basic.sh does, that defeats the purpose of t0000-basic.sh,
> which is to isolate that level of validation in one place. Your
> test also ends up needing updating when such a change to the
> internal happens, so do _not_ do it and leave the low level of
> validation to t0000-basic.sh.
>
> So I would favour this fix. I think this should be ok because we
> depend on Perl anyway.
>
If it isn't, you could always do
sed '1!G;h;$!d'
or
sed -n '1!G;h;$p'
instead.
Both of them are very portable indeed.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
next prev parent reply other threads:[~2008-09-01 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-31 20:03 [PATCH] t6013: Avoid using tac Brian Gernhardt
2008-08-31 22:31 ` [PATCH] t6013: replace use of 'tac' with equivalent Perl Thomas Rast
2008-09-01 12:56 ` Andreas Ericsson [this message]
2008-09-01 16:05 ` Brian Gernhardt
2008-09-01 16:32 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BBE682.2070000@op5.se \
--to=ae@op5.se \
--cc=benji@silverinsanity.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).