From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: catalin.marinas@gmail.com, kha@treskal.com
Cc: git@vger.kernel.org
Subject: [StGIT PATCH] diffcol.sh: Use /bin/bash explicitly
Date: Thu, 04 Sep 2008 00:47:17 +0900 [thread overview]
Message-ID: <48BEB185.2080505@ruby.dti.ne.jp> (raw)
Recent Ubuntu uses dash (Debian Almquist Shell; a lightweight POSIX-
compliant shell derived from ash) as /bin/sh by default. In this case
pager=diffcol.sh doesn't work like this:
> skuribay@ubuntu:~/kernel/linux.git$ stg show
> /home/skuribay/share/stgit/contrib/diffcol.sh: 22: Bad substitution
this is caused by non-bash-compliant /bin/sh.
diffcol.sh is based on Quilt, and Quilt is dependent on bash; Actually
all Quilt scripts use /bin/bash without exceptions. Then it's good for
diffcol.sh to use /bin/bash.
Signed-off-by: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
---
contrib/diffcol.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/diffcol.sh b/contrib/diffcol.sh
index ea9109d..eecc87a 100755
--- a/contrib/diffcol.sh
+++ b/contrib/diffcol.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# Code copied from Quilt (http://savannah.nongnu.org/projects/quilt)
#
next reply other threads:[~2008-09-03 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 15:47 Shinya Kuribayashi [this message]
2008-09-03 16:21 ` [StGIT PATCH] diffcol.sh: Use /bin/bash explicitly Karl Hasselström
2008-09-05 21:35 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BEB185.2080505@ruby.dti.ne.jp \
--to=skuribay@ruby.dti.ne.jp \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).