From: Johannes Sixt <j.sixt@viscovery.net>
To: dhruva <dhruva@ymail.com>
Cc: Kevin Yu <yujie052@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] Windows: git-shell can be compiled again
Date: Mon, 08 Sep 2008 12:46:55 +0200 [thread overview]
Message-ID: <48C5029F.2010307@viscovery.net> (raw)
In-Reply-To: <532046.43033.qm@web95005.mail.in2.yahoo.com>
From: Johannes Sixt <johannes.sixt@telecom.at>
The reason that git-shell was excluded from the Windows build was that
our compatibility layer needed stuff that was removed when we tried to
link less of the git library into git-shell. Since 4cfc24afc9ff the
complete library is linked again, so we can build git-shell on Windows
as well. (This fixes 'make install', which depends on that git-shell
is always built.)
Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
---
dhruva schrieb:
> I cloned the git repo from 'git://git2.kernel.org/pub/scm/git/git.git'.
> I had an earlier msysGIT with build environment. I just got into the msys
> (bash) environment and ran a 'gmake'. It built fine on Windows XP.
This is good to know.
> A trivial issue in install:
> 'gmake install' had a small issue in trying to install non existant
> 'git-shell.exe'. The following trivial patch on master to Makefile
> handles that:
Thanks for bringing up the issue. I was a bit careless reviewing the
changes in that area. Here is a better fix.
-- Hannes
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index dfed7ba..37575f4 100644
--- a/Makefile
+++ b/Makefile
@@ -296,6 +296,7 @@ PROGRAMS += git-pack-redundant$X
PROGRAMS += git-patch-id$X
PROGRAMS += git-receive-pack$X
PROGRAMS += git-send-pack$X
+PROGRAMS += git-shell$X
PROGRAMS += git-show-index$X
PROGRAMS += git-unpack-file$X
PROGRAMS += git-update-server-info$X
@@ -834,7 +835,6 @@ EXTLIBS += -lz
ifndef NO_POSIX_ONLY_PROGRAMS
PROGRAMS += git-daemon$X
PROGRAMS += git-imap-send$X
- PROGRAMS += git-shell$X
endif
ifndef NO_OPENSSL
OPENSSL_LIBSSL = -lssl
--
1.6.0.1.1208.g0bd3.dirty
next prev parent reply other threads:[~2008-09-08 10:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 8:22 What's the status of MinGW port dhruva
2008-09-08 10:46 ` Johannes Sixt [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-08 11:31 [PATCH] Windows: git-shell can be compiled again dhruva
2008-09-08 11:53 ` Johannes Sixt
2008-09-08 12:12 dhruva
2008-09-08 12:22 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C5029F.2010307@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=dhruva@ymail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=yujie052@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).