From: Paolo Bonzini <bonzini@gnu.org>
To: Sergio Callegari <sergio.callegari@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Management of opendocument (openoffice.org) files in git
Date: Tue, 16 Sep 2008 08:24:39 +0200 [thread overview]
Message-ID: <48CF5127.5040507@gnu.org> (raw)
> profile_unzip=PROFILE_UNZIP_${profile}
> profile_zip=PROFILE_ZIP_${profile}
> UNZIP_OPTS=${!profile_unzip}
> ZIP_OPTS=${!profile_zip}
Can be written (in pure bourne shell) as
eval UNZIP_OPTS=\$PROFILE_UNZIP_${profile}
eval ZIP_OPTS=\$PROFILE_ZIP_${profile}
> --unzip_opts)
> UNZIP_OPTS=${UNZIP_OPTS} $2
Missing quotes:
UNZIP_OPTS="${UNZIP_OPTS} $2"
It could also be a good idea to do
UNZIP_OPTS="${UNZIP_OPTS} `echo $2 | sed 'y/,/ /' `"
(compare with the -Wa/-Wl/-Wp options of gcc) so you can do
[filter "opendocument"]
clean = "rezip --unzip-opts -b,-qq,-X --zip-opts -q,-r,-D,-0"
smudge = "rezip --unzip-opts -b,-qq,-X --zip-opts -q,-r,-D,-6"
And maybe -b,-qq,-X and -q,-r respectively could be added by default?
Anyway, nice script, thanks!
Paolo
next reply other threads:[~2008-09-16 6:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 6:24 Paolo Bonzini [this message]
2008-09-16 7:05 ` Management of opendocument (openoffice.org) files in git Sergio Callegari
2008-09-16 8:12 ` Paolo Bonzini
2008-10-02 12:52 ` Michael J Gruber
2008-10-10 8:12 ` Peter Krefting
-- strict thread matches above, loose matches on Subject: below --
2008-09-15 22:40 Sergio Callegari
2008-09-16 6:45 ` Matthieu Moy
2008-09-16 7:41 ` Sergio Callegari
2008-09-16 7:09 ` Johannes Sixt
2008-09-16 7:41 ` Sergio Callegari
2008-09-16 7:52 ` Johannes Sixt
2008-09-16 16:04 ` Avery Pennarun
2008-09-16 19:28 ` Stephen R. van den Berg
2008-09-16 21:13 ` Robin Rosenberg
2008-09-23 11:08 ` Peter Krefting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48CF5127.5040507@gnu.org \
--to=bonzini@gnu.org \
--cc=git@vger.kernel.org \
--cc=sergio.callegari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).