From: Andreas Ericsson <ae@op5.se>
To: Jonathan del Strother <maillist@steelskies.com>
Cc: Miklos Vajna <vmiklos@frugalware.org>,
git@vger.kernel.org, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH] Teach git diff about Objective-C syntax
Date: Thu, 18 Sep 2008 08:50:38 +0200 [thread overview]
Message-ID: <48D1FA3E.6020102@op5.se> (raw)
In-Reply-To: <57518fd10809171214u3b5b3b96yc432c1c410faf8b4@mail.gmail.com>
Jonathan del Strother wrote:
> On Wed, Sep 17, 2008 at 4:55 PM, Miklos Vajna <vmiklos@frugalware.org> wrote:
>> On Wed, Sep 17, 2008 at 04:31:17PM +0100, Jonathan del Strother <maillist@steelskies.com> wrote:
>>> I was changing it to match the style in the existing java pattern (and
>>> my objc pattern). You think the java one should be changed to match
>>> the pascal one, then?
>> The point is that it's unrelated, so you should not change that part in
>> the same patch. Send a separate patch if you want to do something
>> unrelated to Objective-C.
>
> Johannes already convinced me to do it as a separate patch. Andreas
> seems to think that even if that change were in a separate patch, it
> is pure nonsense. I think it's pretty subjective - I was just making
> things consistent.
My apologies. I started writing that reply before Dscho's one got to the
list. Then it was lunch-time, so I didn't send it until Dscho's reply
was already answered by you.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
next prev parent reply other threads:[~2008-09-18 6:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 23:21 [PATCH] Teach git diff about Objective-C syntax Jonathan del Strother
2008-09-16 23:39 ` Miklos Vajna
2008-09-17 0:07 ` Jonathan del Strother
2008-09-17 10:49 ` Jonathan del Strother
2008-09-17 11:06 ` Johannes Schindelin
2008-09-17 12:26 ` Jonathan del Strother
2008-09-17 13:29 ` Jonathan del Strother
2008-09-17 15:03 ` Andreas Ericsson
2008-09-17 15:31 ` Jonathan del Strother
2008-09-17 15:55 ` Miklos Vajna
2008-09-17 19:14 ` Jonathan del Strother
2008-09-17 20:44 ` Junio C Hamano
2008-09-17 23:30 ` Jonathan del Strother
2008-09-30 23:46 ` [PATCH v2] " Jonathan del Strother
2008-10-01 0:52 ` Brandon Casey
2008-10-01 19:28 ` [PATCH] xdiff-interface.c: strip newline (and cr) from line before pattern matching Brandon Casey
2008-10-01 20:05 ` Johannes Schindelin
2008-10-02 10:29 ` Jonathan del Strother
2008-10-02 10:40 ` [PATCH v2] Teach git diff about Objective-C syntax Jonathan del Strother
2008-09-18 6:50 ` Andreas Ericsson [this message]
2008-09-17 13:37 ` [PATCH] " Jonathan del Strother
2008-09-17 14:28 ` Johannes Schindelin
2008-09-17 14:32 ` Jonathan del Strother
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D1FA3E.6020102@op5.se \
--to=ae@op5.se \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=maillist@steelskies.com \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).