Git development
 help / color / mirror / Atom feed
From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Charles Bailey <charles@hashpling.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/1] Make git archive respect core.autocrlf when creating zip format archives
Date: Thu, 18 Sep 2008 22:41:00 +0200	[thread overview]
Message-ID: <48D2BCDC.6060809@lsrfire.ath.cx> (raw)
In-Reply-To: <20080918200120.GB8631@hashpling.org>

Charles Bailey schrieb:
> There is currently no call to git_config at the start of cmd_archive.
> When creating tar archives the core config is read as a side-effect of
> reading the tar specific config, but this doesn't happen for zip
> archives.
> 
> The consequence is that in a configuration with core.autocrlf set,
> although files in a tar archive are created with crlf line endings,
> files in a zip archive retain unix line endings.

The patches look good, but it took me a while to realize that there are
two of them (0/1 and 1/1). :)

Thanks,
René

      parent reply	other threads:[~2008-09-18 20:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1a7cc4db062b7df0dae0f27b29dba66c9d917e59.1221767629.git.charles@hashpling.org>
2008-09-18 20:01 ` [PATCH 1/1] Make git archive respect core.autocrlf when creating zip format archives Charles Bailey
2008-09-18 20:08   ` Charles Bailey
2008-09-18 20:21   ` Andreas Ericsson
2008-09-18 20:29     ` [PATCH 1/1] Make git archive respect core.autocrlf when creating Charles Bailey
2008-09-18 20:53       ` Sverre Rabbelier
2008-09-18 20:41   ` René Scharfe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48D2BCDC.6060809@lsrfire.ath.cx \
    --to=rene.scharfe@lsrfire.ath.cx \
    --cc=charles@hashpling.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox