From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Ericsson Subject: Re: [TopGit PATCH] .gitignore += vim swap files Date: Fri, 19 Sep 2008 09:51:25 +0200 Message-ID: <48D359FD.90203@op5.se> References: <1221755370-6817-1-git-send-email-kirr@landau.phys.spbu.ru> <1221755370-6817-2-git-send-email-kirr@landau.phys.spbu.ru> <36ca99e90809181038o74c73121j59849b3f24fe6469@mail.gmail.com> <20080919050612.GA4423@roro3> <36ca99e90809190010n40d0a4w26975e87e17a822e@mail.gmail.com> <20080919072851.GD4423@roro3> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Bert Wesarg , Daniel Barkalow , Petr Baudis , Git Mailing List To: Kirill Smelkov X-From: git-owner@vger.kernel.org Fri Sep 19 09:55:24 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kgaph-00066W-50 for gcvg-git-2@gmane.org; Fri, 19 Sep 2008 09:55:17 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750960AbYISHvl (ORCPT ); Fri, 19 Sep 2008 03:51:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750843AbYISHvl (ORCPT ); Fri, 19 Sep 2008 03:51:41 -0400 Received: from mail.op5.se ([193.201.96.20]:51170 "EHLO mail.op5.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbYISHvk (ORCPT ); Fri, 19 Sep 2008 03:51:40 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.op5.se (Postfix) with ESMTP id 2909A1B800A6; Fri, 19 Sep 2008 09:41:44 +0200 (CEST) X-Virus-Scanned: amavisd-new at X-Spam-Flag: NO X-Spam-Score: -2.659 X-Spam-Level: X-Spam-Status: No, score=-2.659 tagged_above=-10 required=6.6 tests=[AWL=-0.316, BAYES_00=-2.599, RDNS_NONE=0.1, SUBJECT_FUZZY_TION=0.156] Received: from mail.op5.se ([127.0.0.1]) by localhost (mail.op5.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k82W8S-aq6ZV; Fri, 19 Sep 2008 09:41:41 +0200 (CEST) Received: from clix.int.op5.se (unknown [172.27.78.10]) by mail.op5.se (Postfix) with ESMTP id 1540F1B80081; Fri, 19 Sep 2008 09:41:40 +0200 (CEST) User-Agent: Thunderbird 2.0.0.16 (X11/20080723) In-Reply-To: <20080919072851.GD4423@roro3> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Kirill Smelkov wrote: > On Fri, Sep 19, 2008 at 09:10:24AM +0200, Bert Wesarg wrote: >> On Fri, Sep 19, 2008 at 07:06, Kirill Smelkov wrote: >>> On Thu, Sep 18, 2008 at 03:30:35PM -0400, Daniel Barkalow wrote: >>>> On Thu, 18 Sep 2008, Bert Wesarg wrote: >>>> >>>>> On Thu, Sep 18, 2008 at 18:29, Kirill Smelkov wrote: >>>>>> Signed-off-by: Kirill Smelkov >>>>>> --- >>>>>> .gitignore | 2 ++ >>>>>> 1 files changed, 2 insertions(+), 0 deletions(-) >>>>>> >>>>>> diff --git a/.gitignore b/.gitignore >>>>>> index 8868f2d..aa39db4 100644 >>>>>> --- a/.gitignore >>>>>> +++ b/.gitignore >>>>>> @@ -18,3 +18,5 @@ tg-import.txt >>>>>> tg-remote >>>>>> tg-remote.txt >>>>>> tg >>>>>> + >>>>>> +*.swp >>>>> can't you do this in your .git/info/excludes? >>>> It's generally better to put a core.excludesfile entry in your >>>> ~/.gitconfig pointing to a ignore file with editor temporaries for the >>>> editor(s) you personally use. This will then apply to all git projects you >>>> work on. >>> Yes, this makes sense, thanks. >>> >>> I've had to add the following to my ~/.gitconfig >>> >>> [core] >>> excludesfile= /home/kirr/.gitignore-kirr >>> >>> >>> because it does not work when '~' is used for $HOME >>> >>> [core] >>> excludesfile= ~/.gitignore-kirr # does not work >> Have you tried: >> >> [core] >> excludesfile = .gitignore-kirr >> There was a discussion about relative files in config. but I didn't tried this. > > It does not work for me -- it picks ./.gitignore-kirr instead of > ~/.gitignore-kirr > >> Anyway, I think this is the best solution. Don't globber the repos with this. > > Don't you care more about machines than humans? :) > > I think when we work on a tree, all the autogenerated files should be > ignored. This includes *.o and friends for sure, but since we also use > editors, and most people use same editors it makes sense to tune repo to > be ready to hack on with common setups. > Most people do not use same editors. In our office there's 8 programmers and 6 editors in use (geany, jed, vim, nedit, zend studio, kate). > And I think this > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7088655477b51a5a248fa54190388e1283ba7ebf > > just justifies my words. > If topgit had 4374 contributors since 10 minor versions back, I'd be more inclined to agree with you. Even so, you'll have to accept that this patch gets dropped[1] and stop trying to argue for it after it's already been discussed (at length). [1] I'm not too sure who the topgit maintainer actually is, but the majority seem to be against this patch. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231