From: Andreas Ericsson <ae@op5.se>
To: Stephen Haberman <stephen@exigencecorp.com>
Cc: git@vger.kernel.org
Subject: Re: interactive rebase not rebasing
Date: Wed, 01 Oct 2008 17:26:39 +0200 [thread overview]
Message-ID: <48E396AF.2000100@op5.se> (raw)
In-Reply-To: <20081001095225.d28de16a.stephen@exigencecorp.com>
Stephen Haberman wrote:
>
> But given /this/ scenario (hehe), with the implementation's existing
> explicit usage of "--left-right --cherry-pick" to drop no-op commits,
> but then it's forgetting of this information later, leading to `git
> rebase` not performing a rebase at all, I think it is an obvious bug,
> and one that can be fixed without changing any of `git rebase`s
> existing semantics.
>
Agreed.
>> Merely that you should think hard about it and then make sure it
>> doesn't break anything people are already doing today with the current
>> toolset.
>
> I've attempted to do that. Now that I sent in the patch, if you could
> review it, I would appreciate your feedback.
I'm heading home from work now. I'll look it over tonight or tomorrow
morning. Thanks for the confidence :-)
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
next prev parent reply other threads:[~2008-10-01 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 4:50 interactive rebase not rebasing Stephen Haberman
2008-09-29 6:42 ` Andreas Ericsson
2008-10-01 6:03 ` Stephen Haberman
2008-10-01 7:50 ` Andreas Ericsson
2008-10-01 14:52 ` Stephen Haberman
2008-10-01 15:26 ` Andreas Ericsson [this message]
2008-10-01 17:13 ` Stephen Haberman
2008-10-01 18:31 ` Shawn O. Pearce
2008-10-01 21:26 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E396AF.2000100@op5.se \
--to=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=stephen@exigencecorp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).