git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rogan Dawes <lists@dawes.za.net>
To: unlisted-recipients:; (no To-header on input)
Cc: Petr Baudis <pasky@suse.cz>, git@vger.kernel.org
Subject: Re: [FYI][PATCH] Execute testsuite on existing Git installation
Date: Fri, 03 Oct 2008 17:59:49 +0200	[thread overview]
Message-ID: <48E64175.5090709@dawes.za.net> (raw)
In-Reply-To: <48E6314B.3090609@dawes.za.net>

Rogan Dawes wrote:
> Petr Baudis wrote:
>> When I joined here, one of the first tasks I had was to "verify if the
>> existing system-wide Git installation works fine on the local Linux
>> setup (of unknown qualities)". I couldn't think of anything better than
>> to run the Git testsuite, but using the system-wide Git instead of
>> locally compiled one.
>>
>> This extremely dirty patch achieves this; patch testsuite of Git version
>> corresponding to the system-wide installation, of course. You will still
>> need to make the test helpers.
>>
>> I don't have any real interest on developing this further or tidying it
>> up, but I have thought that someone might find this useful to just use
>> or push forward, so here it goes.
>>
>> Signed-off-by: Petr Baudis <petr.baudis@novartis.com>
>>
> 
> Perhaps a stupid question, but might it not be easier to add the git 
> build dir to the front of the PATH, and then remove the explicit paths?
> 
> I realise that if the build was unsuccessful, you may end up executing a 
> different version of git than you expect, though.
> 
> Rogan
> 

Or, make a "BUILD_DIR" variable, and replace ../git with ${BUILD_DIR}git 
throughout, and make BUILD_DIR == '../' for the normal case, and '' for 
the less common case of testing the existing installation.

Or, make ../git a symlink to the installed git binary. This is probably 
the simplest, in fact, requiring the least surgery - i.e. none for those 
who don't need this functionality.

Rogan

      reply	other threads:[~2008-10-03 16:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-03 13:13 [FYI][PATCH] Execute testsuite on existing Git installation Petr Baudis
2008-10-03 14:50 ` Rogan Dawes
2008-10-03 15:59   ` Rogan Dawes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E64175.5090709@dawes.za.net \
    --to=lists@dawes.za.net \
    --cc=git@vger.kernel.org \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).