From: Johannes Sixt <j.sixt@viscovery.net>
To: Dmitry Potapov <dpotapov@gmail.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH] error out if path is invalid
Date: Mon, 06 Oct 2008 09:02:22 +0200 [thread overview]
Message-ID: <48E9B7FE.2000503@viscovery.net> (raw)
In-Reply-To: <1223172881-4948-2-git-send-email-dpotapov@gmail.com>
Dmitry Potapov schrieb:
> if (!verify_path(path))
> - return -1;
> + return error("Invalid path '%s'", path);
Look at this change. Didn't the code error out before, too? Same in the
other cases. Hence, your patch subject does not describe the patch. And
I'd appreciate if you could at least show an example in the description
what the patch fixes.
-- Hannes
next prev parent reply other threads:[~2008-10-06 7:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-05 0:40 [PATCH] make prefix_path() never return NULL Dmitry Potapov
2008-10-05 2:14 ` [PATCH] do not segfault if make_cache_entry failed Dmitry Potapov
2008-10-05 2:14 ` [PATCH] error out if path is invalid Dmitry Potapov
2008-10-06 7:02 ` Johannes Sixt [this message]
2008-10-07 0:22 ` Dmitry Potapov
2008-10-07 6:03 ` Johannes Sixt
2008-10-11 16:39 ` [PATCH] print an error message for invalid path Dmitry Potapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E9B7FE.2000503@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).