From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Ericsson Subject: Re: [RFC PATCH] describe: Make --tags and --all match lightweight tags more often Date: Sun, 12 Oct 2008 20:13:23 +0200 Message-ID: <48F23E43.4010409@op5.se> References: <20081010165952.GI8203@spearce.org> <48F12CF8.505@op5.se> <20081012180040.GC4856@spearce.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: git@vger.kernel.org, Junio C Hamano , Pierre Habouzit , Erez Zilber To: "Shawn O. Pearce" X-From: git-owner@vger.kernel.org Sun Oct 12 20:14:56 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kp5Sv-0003hf-Af for gcvg-git-2@gmane.org; Sun, 12 Oct 2008 20:14:53 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754647AbYJLSNa (ORCPT ); Sun, 12 Oct 2008 14:13:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754577AbYJLSN3 (ORCPT ); Sun, 12 Oct 2008 14:13:29 -0400 Received: from mail.op5.se ([193.201.96.20]:36189 "EHLO mail.op5.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754520AbYJLSN3 (ORCPT ); Sun, 12 Oct 2008 14:13:29 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.op5.se (Postfix) with ESMTP id D775F1B80050; Sun, 12 Oct 2008 20:06:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at X-Spam-Flag: NO X-Spam-Score: -2.69 X-Spam-Level: X-Spam-Status: No, score=-2.69 tagged_above=-10 required=6.6 tests=[AWL=-0.191, BAYES_00=-2.599, RDNS_NONE=0.1] Received: from mail.op5.se ([127.0.0.1]) by localhost (mail.op5.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n52aobSSEuXX; Sun, 12 Oct 2008 20:06:04 +0200 (CEST) Received: from clix.int.op5.se (unknown [172.27.78.14]) by mail.op5.se (Postfix) with ESMTP id B763B1B8004E; Sun, 12 Oct 2008 20:06:02 +0200 (CEST) User-Agent: Thunderbird 2.0.0.16 (X11/20080723) In-Reply-To: <20081012180040.GC4856@spearce.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Shawn O. Pearce wrote: > Andreas Ericsson wrote: >> Shawn O. Pearce wrote: >>> If the caller supplies --tags they want the lightweight, unannotated >>> tags to be searched for a match. If a lightweight tag is closer >>> in the history, it should be matched, even if an annotated tag is >>> reachable further back in the commit chain. >>> >>> The same applies with --all when matching any other type of ref. >>> >> In 99% of the cases, "--all" will then give back the currently >> checked out branch unless a revision is specified, right? > > Yup. > > `git describe --all` or `git describe --all HEAD` > > would kick back the current branch you have checked out, assuming > you have a real branch under refs/heads and not some detached HEAD. > > IMHO, that's what the user asked for. > True. I think this will raise questions of its usability though, in particular if it considers remote branches too. Otoh, I've never seen the use for "git describe --all" earlier either, so I guess I think differently from those who want this feature. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231