From: Pete Harlan <pgit@pcharlan.com>
To: Karl Chen <quarl@cs.berkeley.edu>
Cc: Git mailing list <git@vger.kernel.org>
Subject: Re: git-svnimport.perl bug when copy source path has a revision
Date: Wed, 15 Oct 2008 23:43:43 -0700 [thread overview]
Message-ID: <48F6E29F.1050807@pcharlan.com> (raw)
In-Reply-To: <quack.20081015T1211.lth8wsp65dk@roar.cs.berkeley.edu>
Karl Chen wrote:
> This looks like a bug in git-svnimport.perl. If a tag (or
> branch?) is created retroactively, git-svnimport doesn't respect
> the copy source revision.
>
> To reproduce:
>
> svnadmin create somerepo; export R=file://$PWD/somerepo
>
> svn co $R wc && cd wc
>
> mkdir trunk tags && svn add trunk tags && svn commit -m "" # rev 1
>
> cd trunk
> echo a > a
> echo b > b
> echo c > c
>
> svn add a && svn commit -m "commit a" # rev 2
> svn add b && svn commit -m "commit b" # rev 3
> # Copy from revision 2 instead of HEAD:
> svn cp -m "tag rev 2" $R/trunk@2 $R/tags/mytag # rev 4
> svn add c && svn commit -m "commit c" # rev 5
>
> svn ls $R/tags/mytag
> # Lists only 'a'
>
> mkdir /tmp/gitrepo && cd /tmp/gitrepo
> perl /usr/share/doc/git-core/contrib/examples/git-svnimport.perl $R
>
> git log mytag
> # 'mytag' includes "commit b"; it was created as if it were tagged
> # at r3; the "@2" was ignored.
If you replace this:
> perl /usr/share/doc/git-core/contrib/examples/git-svnimport.perl $R
with:
git svn init -T trunk -t tags $R
git svn fetch
git log tags/mytag
you get a log that doesn't include "commit b". (And it does include the
tag commit, as svn does.) tags/mytag is a branch, visibile via "git
branch -r", instead of a tag. I'm not fluent enough in git svn to know
if this is a bug or a feature.
According to git logs (8cb070a4, fee9832a), git-svnimport.perl hasn't
been maintained in a while, presumably because git svn provides a
superset of its functionality.
HTH,
--Pete
next prev parent reply other threads:[~2008-10-16 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 19:11 git-svnimport.perl bug when copy source path has a revision Karl Chen
2008-10-16 6:43 ` Pete Harlan [this message]
2008-10-16 18:36 ` Karl Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F6E29F.1050807@pcharlan.com \
--to=pgit@pcharlan.com \
--cc=git@vger.kernel.org \
--cc=quarl@cs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).