From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Bert Wesarg <bert.wesarg@googlemail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/3] add alloc_ref_with_prefix()
Date: Sat, 18 Oct 2008 11:39:22 +0200 [thread overview]
Message-ID: <48F9AECA.3020606@lsrfire.ath.cx> (raw)
In-Reply-To: <36ca99e90810180227u367783f6vc3b7af0176f6df06@mail.gmail.com>
>> +static struct ref *alloc_ref_with_prefix(const char *prefix, size_t prefixlen,
>> + const char *name)
>> +{
>> + size_t len = strlen(name);
>> + struct ref *ref = xcalloc(1, sizeof(struct ref) + prefixlen + len + 1);
>> + memcpy(ref->name, prefix, prefixlen);
>> + memcpy(ref->name + prefixlen, name, len);
> Where does you \0-terminate the string?
xcalloc() calls calloc(), which zeroes the memory.
René
next prev parent reply other threads:[~2008-10-18 9:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-18 8:37 [PATCH 1/3] add alloc_ref_with_prefix() René Scharfe
2008-10-18 8:41 ` [PATCH 2/3] use alloc_ref_from_str() everywhere René Scharfe
2008-10-18 8:44 ` [PATCH 3/3] make alloc_ref_from_str() the new alloc_ref() René Scharfe
2008-10-18 9:27 ` [PATCH 1/3] add alloc_ref_with_prefix() Bert Wesarg
2008-10-18 9:39 ` René Scharfe [this message]
2008-10-18 12:07 ` Bert Wesarg
2008-10-18 12:35 ` René Scharfe
2008-10-20 10:34 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F9AECA.3020606@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).