From: Johannes Sixt <j.sixt@viscovery.net>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Git Mailing List <git@vger.kernel.org>,
Davide Libenzi <davidel@xmailserver.org>
Subject: Re: [PATCH, RFC] diff: add option to show context between close chunks
Date: Tue, 21 Oct 2008 08:09:33 +0200 [thread overview]
Message-ID: <48FD721D.9030105@viscovery.net> (raw)
In-Reply-To: <48FCC8A1.5090109@lsrfire.ath.cx>
René Scharfe schrieb:
> I have to admit my main motivation was that one line gap, where a chunk
> header hid an interesting line of context. Showing it didn't change the
> length of the patch, so I found this to be a sad wastage.
"Wastage" is relative. For a given patch, the one line of context that was
hidden by the hunk header would be welcome by a human reader, but it is
not necessarily useful if the patch is to be applied, in particular, if it
is applied to a version of the file that has *more* than one line between
the hunk contexts. This is the reason that diff does not produce 7 lines
of context between changes in -U3 mode ("you asked for 3 lines of context,
you get 3 lines of context").
BTW, nomenclature seems to have settled at the word "hunk", not "chunk".
-- Hannes
next prev parent reply other threads:[~2008-10-21 6:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-19 17:59 [PATCH, RFC] diff: add option to show context between close chunks René Scharfe
2008-10-20 14:32 ` Johannes Sixt
2008-10-20 18:06 ` René Scharfe
2008-10-21 6:09 ` Johannes Sixt [this message]
2008-10-21 20:45 ` René Scharfe
2008-10-20 23:43 ` Junio C Hamano
2008-10-21 6:35 ` Johannes Sixt
2008-10-21 7:12 ` Junio C Hamano
2008-10-21 11:20 ` Jeff King
2008-10-21 20:48 ` René Scharfe
2008-10-21 18:16 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FD721D.9030105@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=davidel@xmailserver.org \
--cc=git@vger.kernel.org \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).