From: Andreas Ericsson <ae@op5.se>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
SLONIK.AZ@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] git-fetch should not strip off ".git" extension
Date: Wed, 22 Oct 2008 09:55:15 +0200 [thread overview]
Message-ID: <48FEDC63.8090104@op5.se> (raw)
In-Reply-To: <81b0412b0810211543p6cb8c4ej49fb7fe70c3e2917@mail.gmail.com>
Alex Riesen wrote:
> 2008/10/22 Junio C Hamano <gitster@pobox.com>:
>> "Alex Riesen" <raa.lkml@gmail.com> writes:
>>> FWIW, I support Leo on that. The "established" behavior is stupid.
>> I am not inclined to respond to such an emotional argument. On the other
>> hand, it is fair to say that the existing behaviour is established,
>> because it is backed by a long history, which you can objectively verify.
>
> I found it illogical (well, stupid) and inconvinient
>
>> *1* It would be a different matter if the patch at the same time removed
>> the fetch/clone DWIMmery. At least such a patch would be internally self
>> consistent.
>
> Good idea.
No. Bad idea. That would not only break people's fetch configurations if
they've done clone on repos without passing .git, but also mean users
would have to remember if a particular server names their bare repos
"project.git".
If you remove *all* DWIMmery from fetch/clone, you'd also break people's
expectations when they're fetching from each other, as they'd have to pass
"git://devpeer/project/.git" instead of just "git://devpeer/project", which
is what *looks* sane.
A good idea would be to always report the name the user used. 'git clone'
already does that, recording the non-DWIMmed URL in the remotes config.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
next prev parent reply other threads:[~2008-10-22 7:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-18 11:59 [PATCH] git-fetch should not strip off ".git" extension Leo Razoumov
2008-10-20 10:36 ` Andreas Ericsson
2008-10-20 15:08 ` Leo Razoumov
2008-10-20 18:37 ` Junio C Hamano
2008-10-21 10:23 ` Leo Razoumov
2008-10-21 16:56 ` Junio C Hamano
2008-10-21 22:06 ` Alex Riesen
2008-10-21 22:36 ` Junio C Hamano
2008-10-21 22:43 ` Alex Riesen
2008-10-22 7:55 ` Andreas Ericsson [this message]
2008-10-21 23:35 ` Junio C Hamano
2008-10-22 11:35 ` Leo Razoumov
2008-10-22 11:50 ` Leo Razoumov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FEDC63.8090104@op5.se \
--to=ae@op5.se \
--cc=SLONIK.AZ@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).