git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Steve Frécinaux" <nudrema@gmail.com>
To: Arafangion <thestar@fussycoder.id.au>
Cc: David Symonds <dsymonds@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] Cached the git configuration, which is now noticibly faster on windows.
Date: Mon, 10 Nov 2008 09:38:11 +0100	[thread overview]
Message-ID: <4917F2F3.8000408@gmail.com> (raw)
In-Reply-To: <1226127130.8252.6.camel@therock.nsw.bigpond.net.au>

Arafangion wrote:
> On Fri, 2008-11-07 at 21:19 -0800, David Symonds wrote:
> <snip>
>> _gitConfig = None
>> def gitConfig(key):
>>   if _gitConfig is None:
>>     lines = read_pipe("git config -l", ignore_error=True).readlines():
>>     _gitConfig = dict([l.strip().split('=', 1) for l in lines])
>>   return _gitConfig.get(key, None)
> 
> That certainly is better, if one can assume that git's configuration is
> small. (And relative to the memory usage of the script, it will
> definetly be small).

What about using git config --get-regexp to only get the p4-related 
settings ?

I don't really know the options used by git-p4, but something like this 
seems like a good candidate to address every trade-off concerns?

git-config --get-regexp '^(p4|user)\.'

  reply	other threads:[~2008-11-10  8:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-08  3:22 [PATCH 1/2] Added support for purged files and also optimised memory usage John Chapman
2008-11-08  3:22 ` [PATCH 2/2] Cached the git configuration, which is now noticibly faster on windows John Chapman
2008-11-08  5:19   ` David Symonds
2008-11-08  6:52     ` Arafangion
2008-11-10  8:38       ` Steve Frécinaux [this message]
2008-11-08 10:13     ` Jakub Narebski
2008-11-09 18:33   ` Junio C Hamano
2008-11-10  3:50     ` Han-Wen Nienhuys
2008-11-10  9:46     ` Simon Hausmann
2008-11-12  0:50       ` Junio C Hamano
2008-11-12 11:54         ` Arafangion

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4917F2F3.8000408@gmail.com \
    --to=nudrema@gmail.com \
    --cc=dsymonds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=thestar@fussycoder.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).