git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Paul Mackerras <paulus@samba.org>
Cc: Alexander Gavrilov <angavrilov@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH (GITK)] gitk: Fix transient windows on Win32 and MacOS.
Date: Wed, 12 Nov 2008 09:28:08 +0100	[thread overview]
Message-ID: <491A9398.1060100@viscovery.net> (raw)
In-Reply-To: <18714.36964.666759.654975@cargo.ozlabs.ibm.com>

Paul Mackerras schrieb:
> Johannes Sixt writes:
>> Alexander Gavrilov schrieb:
>>> Transient windows cause problems on these platforms:
>> ...
>>> diff --git a/gitk b/gitk
>>> index 9b2a6e5..e6aafe8 100755
>> I'd appreciate if you could make it a habit to base your patches on
>> versions of gitk etc. that are available from a public repository
> 
> You mean, like, git://git.kernel.org/pub/scm/gitk/gitk.git, for
> instance? :)  That is the primary repository for gitk and it seems to
> be what Alexander bases his patches on.

Yes, I mean exactly this repository. It doesn't have 9b2a6e5:

$ git fetch gitk
$ git show 9b2a6e5 --
fatal: bad revision '9b2a6e5'

I assume that Alexander has another patch applied in addition to the one
that he submitted, which, therefore, is no longer "based on a publically
available version".

-- Hannes

  reply	other threads:[~2008-11-12  8:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-11 20:55 [PATCH (GITK)] gitk: Fix transient windows on Win32 and MacOS Alexander Gavrilov
2008-11-12  7:15 ` Johannes Sixt
2008-11-12  8:14   ` Paul Mackerras
2008-11-12  8:28     ` Johannes Sixt [this message]
2008-11-12 10:36       ` Alexander Gavrilov
2008-11-13 11:41         ` Paul Mackerras
2008-11-13 11:41 ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491A9398.1060100@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=angavrilov@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).