From: Paolo Bonzini <bonzini@gnu.org>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH 1/9 v4] bisect: add "git bisect replace" subcommand
Date: Thu, 13 Nov 2008 17:41:07 +0100 [thread overview]
Message-ID: <491C58A3.2000609@gnu.org> (raw)
In-Reply-To: <200811121515.48277.chriscool@tuxfamily.org>
> Of course it also depends on how often people use "git bisect", but it seems
> that there are people out there bisecting very frequently and that these
> people care very much about bisectability of the tree.
What about "git bisect cherry-pick COMMIT" which would do a "cherry-pick
-n" of COMMIT after every bisection unless COMMIT is in the ancestry of
the current revision? So if you have to bisect between A and B, and you
know that a bug present between A and B was fixed by C, you could do
git bisect good A
git bisect bad B
git bisect cherry-pick C
This would subsume Junio's proposal: users could also set up a few
special bisect/set-debug-to-1, bisect/remove-cflags-o2 and so on patches
that you could use for purposes other than ensuring known bugs are fixed.
Finally, you could have a [bisect] configuration section with entries
like "cherry-pick = BROKEN-SHA1 FIX-SHA1" and "git bisect" would apply
FIX-SHA1 automatically if the bisect tip were in BROKEN-SHA1..FIX-SHA1.
>> Things like paranoid update hook
>> needs to become very careful about refs/replace/ for security reasons,
>> but I think this would make the grafts much easier to use.
>
> I agree that it would make grafts much easier to use (and would be very
> security sensitive).
Not so much. People with public servers could create refs/replace in
the server and give it 400 permissions, and/or git would refuse to
create the refs/replace directory, forcing users to create it manually
unless it is already in the server.
Paolo
next prev parent reply other threads:[~2008-11-13 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 5:39 [PATCH 1/9 v4] bisect: add "git bisect replace" subcommand Christian Couder
2008-11-11 23:23 ` Junio C Hamano
2008-11-12 14:15 ` Christian Couder
2008-11-13 9:46 ` Junio C Hamano
2008-11-13 17:50 ` Christian Couder
2008-11-13 16:41 ` Paolo Bonzini [this message]
2008-11-14 9:34 ` Christian Couder
2008-11-14 10:03 ` Paolo Bonzini
2008-11-15 14:19 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491C58A3.2000609@gnu.org \
--to=bonzini@gnu.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).