From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Sixt Subject: Re: [PATCH] Makefile: introduce NO_PTHREADS Date: Mon, 17 Nov 2008 11:34:21 +0100 Message-ID: <492148AD.1090604@viscovery.net> References: <200811121029.34841.thomas@koch.ro> <371xaQfxsMMQ-9LK24q-nhcS4loEggn8Cj3J1IzfMbzzYDGE6HKbQQ@cipher.nrlssc.navy.mil> <7vtza95h01.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Junio C Hamano , Git Mailing List , Linus Torvalds To: Mike Ralphson X-From: git-owner@vger.kernel.org Mon Nov 17 11:35:47 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1L21SM-0005yG-Na for gcvg-git-2@gmane.org; Mon, 17 Nov 2008 11:35:47 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752074AbYKQKec (ORCPT ); Mon, 17 Nov 2008 05:34:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751945AbYKQKec (ORCPT ); Mon, 17 Nov 2008 05:34:32 -0500 Received: from lilzmailso01.liwest.at ([212.33.55.23]:45768 "EHLO lilzmailso01.liwest.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751819AbYKQKeb (ORCPT ); Mon, 17 Nov 2008 05:34:31 -0500 Received: from cm56-163-160.liwest.at ([86.56.163.160] helo=linz.eudaptics.com) by lilzmailso01.liwest.at with esmtpa (Exim 4.69) (envelope-from ) id 1L21R3-0003H7-0r; Mon, 17 Nov 2008 11:34:25 +0100 Received: from [127.0.0.1] (J6T.linz.viscovery [192.168.1.96]) by linz.eudaptics.com (Postfix) with ESMTP id C1E6E54D; Mon, 17 Nov 2008 11:34:24 +0100 (CET) User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) In-Reply-To: X-Enigmail-Version: 0.95.5 X-Spam-Score: 1.7 (+) X-Spam-Report: ALL_TRUSTED=-1.8, BAYES_99=3.5 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Mike Ralphson schrieb: > 2008/11/15 Linus Torvalds : >> On Sat, 15 Nov 2008, Junio C Hamano wrote: >>> This introduces make variable NO_PTHREADS for platforms that lack the >>> support for pthreads library or people who do not want to use it for >>> whatever reason. When defined, it makes the multi-threaded index >>> preloading into a no-op, and also disables threaded delta searching by >>> pack-objects. >> Ack. Makes sense. > > I'd be minded to make this the default on AIX to keep the prerequisite > list as small as possible, then people can opt-in for the performance > benefits if required. Is pthreads not a standard shipment on AIX? I would set NO_PTHREADS only if we know in advance that there are many installations without pthreads. (And I don't know what the situation is.) BTW, this needs to be squashed in, because we don't have pthreads on Windows: diff --git a/Makefile b/Makefile index ffc9531..3a30b8c 100644 --- a/Makefile +++ b/Makefile @@ -769,6 +769,7 @@ ifneq (,$(findstring MINGW,$(uname_S))) NO_STRCASESTR = YesPlease NO_STRLCPY = YesPlease NO_MEMMEM = YesPlease + NO_PTHREADS = YesPlease NEEDS_LIBICONV = YesPlease OLD_ICONV = YesPlease NO_C99_FORMAT = YesPlease -- Hannes