From: Johannes Sixt <j.sixt@viscovery.net>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Nicolas Pitre <nico@cam.org>, Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Fix handle leak in builtin-pack-objects
Date: Wed, 19 Nov 2008 14:55:59 +0100 [thread overview]
Message-ID: <49241AEF.1080808@viscovery.net> (raw)
In-Reply-To: <81b0412b0811190534r4f71f981s53de415f79e56e25@mail.gmail.com>
Alex Riesen schrieb:
> 2008/11/19 Nicolas Pitre <nico@cam.org>:
>> On Wed, 19 Nov 2008, Johannes Sixt wrote:
>>> The work-around is to write the repacked objects to a file of a different
>>> name, and replace the original after git-pack-objects has terminated.
>>>
>>> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
>> Acked-by: Nicolas Pitre <nico@cam.org>
>
> Are you sure? Will it work in a real repository? Were noone does
> rename the previous pack files into packtmp-something?
Oh, the patch only works around the failure in the test case. In a real
repository there is usually no problem because the destination pack file
does not exist.
The unusual case is where you do this:
$ git rev-list -10 HEAD | git pack-objects foobar
twice in a row: In this case the second invocation fails on Windows
because the destination pack file already exists *and* is open. But not
even git-repack does this even if it is called twice. OTOH, the test case
*does* exactly this.
-- Hannes
next prev parent reply other threads:[~2008-11-19 13:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 11:13 [PATCH] Fix handle leak in builtin-pack-objects Alex Riesen
2008-11-19 11:54 ` Johannes Sixt
2008-11-19 12:13 ` Alex Riesen
2008-11-19 12:26 ` Johannes Sixt
2008-11-19 12:55 ` Nicolas Pitre
2008-11-19 13:06 ` Johannes Sixt
2008-11-19 14:31 ` Nicolas Pitre
2008-11-19 13:34 ` Alex Riesen
2008-11-19 13:55 ` Johannes Sixt [this message]
2008-11-19 14:17 ` Alex Riesen
2008-11-19 14:42 ` Nicolas Pitre
2008-11-19 14:52 ` Johannes Sixt
2008-11-19 16:25 ` [PATCH] compat/mingw.c: Teach mingw_rename() to replace read-only files Johannes Sixt
2008-11-26 13:18 ` [PATCH] Fix handle leak in builtin-pack-objects Alex Riesen
2008-11-26 14:33 ` Nicolas Pitre
2008-11-26 18:43 ` Alex Riesen
2008-12-09 19:26 ` [PATCH] make sure packs to be replaced are closed beforehand Nicolas Pitre
2008-12-09 19:33 ` Alex Riesen
2008-12-10 7:37 ` Johannes Sixt
2008-12-10 8:27 ` Junio C Hamano
2008-12-10 9:36 ` Alex Riesen
2008-11-19 12:45 ` [PATCH] Fix handle leak in builtin-pack-objects Nicolas Pitre
2008-11-19 13:30 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49241AEF.1080808@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).