From: Johannes Sixt <j.sixt@viscovery.net>
To: Vasyl' Vavrychuk <vvavrychuk@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] mmap implementation for mingw.
Date: Fri, 21 Nov 2008 10:44:09 +0100 [thread overview]
Message-ID: <492682E9.3030302@viscovery.net> (raw)
In-Reply-To: <gg5t5s$qc8$1@ger.gmane.org>
Please "reply to all" to keep the Cc list.
Vasyl' Vavrychuk schrieb:
>> Did you notice any differences with this? Or is this change just
>> because-we-can?
> Not yet.
This patch makes sense only if there is a noticable speed improvement. I
doubt that the gain is measurable in the warm-cache case, but in the
cold-cache case we can perhaps indeed save a number of disk accesses if
whole pack files need not be slurped in (which the current mmap
replacements do).
> Maybe write own getpagesize() based on GetSystemInfo()?
It's probably worth it (but only if mmap() makes sense at all).
getpagesize() is used in the "sliding window" code to access pack files,
and then the offset is non-zero and must be aligned properly. Make this a
separate commit.
-- Hannes
next prev parent reply other threads:[~2008-11-21 9:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 2:50 [PATCH] mmap implementation for mingw Vasyl Vavrychuk
2008-11-21 7:59 ` Johannes Sixt
2008-11-21 8:57 ` Vasyl' Vavrychuk
2008-11-21 9:44 ` Johannes Sixt [this message]
2008-11-21 10:48 ` Johannes Schindelin
2008-11-21 20:25 ` Bryan Donlan
2008-11-21 20:51 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492682E9.3030302@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=vvavrychuk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox