[BUG] git bisect visualize crash

[BUG] git bisect visualize crash

[Alejandro Riveira]

i'm using ubuntu 8.10 and git bisect visualize is crashing.
Noticed when bisecting the kernel but it is easily reproducible

in git repository as of today

$ git bisect bad
$ git bisect good HEAD~20

$ git bisect visualize                                                                  (03-12 12:16)
Error in startup script: can't read "notflag": no such variable
    while executing
"expr {!$notflag}"
    ("--not" arm line 2)
    invoked from within
"switch -glob -- $arg {
            "-d" -
            "--date-order" {
                set vdatemode($n) 1
                # remove from origargs in case we hit an unknown option
                set origarg..."
    (procedure "parseviewargs" line 21)
    invoked from within
"parseviewargs $view $args"
    (procedure "start_rev_list" line 27)
    invoked from within
"start_rev_list $curview"
    (procedure "getcommits" line 5)
    invoked from within
"getcommits {}"
    (file "/usr/local/bin/gitk" line 10897)

$ git --version
git version 1.6.1.rc1
$

[PATCH] gitk: fix 'can't read "notflag"'

[Johannes Schindelin]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 973 bytes --]


Sometimes, when calling git bisect visualize, parameters including
a "--not" are passed to gitk, triggering an uninitialized-variable bug
introduced in ee66e089(gitk: Make updates go faster).

Noticed by Alejandro Riveira Fernández.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---

	On Wed, 3 Dec 2008, Alejandro Riveira wrote:

	> $ git bisect visualize                                                                  (03-12 12:16)
	> Error in startup script: can't read "notflag": no such variable

	Alejandro was good enough to test this fix.

 gitk-git/gitk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/gitk-git/gitk b/gitk-git/gitk
index 3353f4a..b18bdf0 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -139,6 +139,7 @@ proc parseviewargs {n arglist} {
     set origargs $arglist
     set allknown 1
     set filtered 0
+    set notflag 0
     set i -1
     foreach arg $arglist {
 	incr i
-- 
1.6.0.4.1189.g8876f

Re: [PATCH] gitk: fix 'can't read "notflag"'

[Johannes Schindelin]

Hi,

On Thu, 4 Dec 2008, Johannes Schindelin wrote:

> diff --git a/gitk-git/gitk b/gitk-git/gitk

D'oh.  Please apply with -p2.

Ciao,
Dscho

Re: [PATCH] gitk: fix 'can't read "notflag"'

[Johannes Sixt]

Johannes Schindelin schrieb:
> On Thu, 4 Dec 2008, Johannes Schindelin wrote:
> 
>> diff --git a/gitk-git/gitk b/gitk-git/gitk
> 
> D'oh.  Please apply with -p2.

No; pull -s subtree before you write this patch ;) It's already fixed in
upstream gitk.

-- Hannes