From: Derrick Stolee <stolee@gmail.com>
To: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH 1/6] commit_graft_pos(): take an oid instead of a bare hash
Date: Thu, 28 Jan 2021 07:57:25 -0500 [thread overview]
Message-ID: <493fcc80-c793-0738-3b8d-b486fd05355b@gmail.com> (raw)
In-Reply-To: <YBJV07YU1Y+siwZc@coredump.intra.peff.net>
On 1/28/2021 1:12 AM, Jeff King wrote:
> All of our callers have an object_id, and are just dereferencing the
> hash field to pass to us. Let's take the actual object_id instead. We
> still access the hash to pass to hash_pos, but it's a step in the right
> direction.
>
> This makes the callers slightly simpler, but also gets rid of the
> untyped pointer, as well as the now-inaccurate name "sha1".
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> I think this one is an obvious cleanup that we'd want whether we go
> further in the series or not.
I agree. Thanks,
-Stolee
next prev parent reply other threads:[~2021-01-28 12:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 6:12 [PATCH 0/6] convert hash_pos() to oid_pos() Jeff King
2021-01-28 6:12 ` [PATCH 1/6] commit_graft_pos(): take an oid instead of a bare hash Jeff King
2021-01-28 12:57 ` Derrick Stolee [this message]
2021-01-28 6:14 ` [PATCH 2/6] rerere: check dirname format while iterating rr_cache directory Jeff King
2021-01-28 6:16 ` [PATCH 3/6] rerere: tighten rr-cache dirname check Jeff King
2021-01-28 22:35 ` Taylor Blau
2021-01-28 6:19 ` [PATCH 4/6] rerere: use strmap to store rerere directories Jeff King
2021-01-28 6:34 ` Jeff King
2021-01-28 19:52 ` Junio C Hamano
2021-01-28 6:38 ` Junio C Hamano
2021-01-28 6:51 ` Jeff King
2021-01-28 6:19 ` [PATCH 5/6] hash_pos(): convert to oid_pos() Jeff King
2021-01-28 22:48 ` Taylor Blau
2021-01-29 1:18 ` Jeff King
2021-01-28 6:20 ` [PATCH 6/6] oid_pos(): access table through const pointers Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493fcc80-c793-0738-3b8d-b486fd05355b@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).