From: Johannes Sixt <j.sixt@viscovery.net>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Daniel Barkalow <barkalow@iabervon.org>,
"Shawn O. Pearce" <spearce@spearce.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: What's cooking in git.git (Nov 2008, #06; Wed, 26)
Date: Fri, 12 Dec 2008 17:45:34 +0100 [thread overview]
Message-ID: <4942952E.1060706@viscovery.net> (raw)
In-Reply-To: <fcaeb9bf0812120813m2949e36ar7905d5688b8f6ecb@mail.gmail.com>
Nguyen Thai Ngoc Duy schrieb:
> On 12/12/08, Junio C Hamano <gitster@pobox.com> wrote:
>> So "git grep -e frotz Documentation/", whether you only check out
>> Documentation or the whole tree, should grep only in Documentation area,
>> and "git grep -e frotz" should grep in the whole tree, even if you happen
>> to have a sparse checkout. By definition, a sparse checkout has no
>> modifications outside the checkout area, so whenever grep wants to look
>> for strings outside the checkout area it should pretend as if the same
>> content as what the index records is in the work tree. This is consistent
>> with the way how "git diff" in a sparsely checked out work tree should
>> behave.
>
> Assume someone is using sparse checkout with KDE git repository. They
> sparse-checkout kdeutils module and do "git grep -e foo". I would
> expect that the command only searches in kdeutils only (and is the
> current behavior).
But what if the same persion notices a #define in a kdeutils header file
and want's to know whether it is unused in order to remove it:
$ git grep FOO
kdeutils/foo.h:#define FOO bar
Conclusion from this output: "It's only defined, but not used anywhere."
But this conclusion is not necessarily correct because FOO could be used
outside kdeutils.
So, no, "git grep" should disregard the checkout area.
-- Hannes
next prev parent reply other threads:[~2008-12-12 16:47 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 0:28 What's cooking in git.git (Nov 2008, #06; Wed, 26) Junio C Hamano
2008-11-27 22:49 ` Johannes Schindelin
2008-11-28 2:06 ` Junio C Hamano
2008-11-28 11:47 ` Johannes Schindelin
2008-11-28 19:20 ` Shawn O. Pearce
2008-11-29 0:13 ` Junio C Hamano
2008-11-29 0:15 ` [PATCH] git add --intent-to-add: fix removal of cached emptiness Junio C Hamano
2008-11-29 3:51 ` [PATCH 1/3] builtin-rm.c: explain and clarify the "local change" logic Junio C Hamano
2008-11-29 3:55 ` [PATCH 2/3] git add --intent-to-add: fix removal of cached emptiness Junio C Hamano
2008-11-29 15:38 ` Sverre Rabbelier
2008-11-30 19:21 ` Jeff King
2008-11-29 3:56 ` [PATCH 3/3] git add --intent-to-add: do not let an empty blob committed by accident Junio C Hamano
2008-11-30 19:14 ` Jeff King
2008-12-01 9:24 ` Junio C Hamano
2008-11-29 1:25 ` What's cooking in git.git (Nov 2008, #06; Wed, 26) Daniel Barkalow
2008-11-29 13:02 ` Nguyen Thai Ngoc Duy
2008-11-30 10:29 ` Nguyen Thai Ngoc Duy
2008-11-30 21:26 ` Daniel Barkalow
2008-12-06 17:26 ` Nguyen Thai Ngoc Duy
2008-12-06 18:39 ` Daniel Barkalow
2008-12-07 12:27 ` Nguyen Thai Ngoc Duy
2008-12-07 21:26 ` Daniel Barkalow
2008-12-08 12:51 ` Nguyen Thai Ngoc Duy
2008-12-08 19:41 ` Daniel Barkalow
2008-12-11 13:04 ` Nguyen Thai Ngoc Duy
2008-12-11 20:30 ` Daniel Barkalow
2008-12-12 1:41 ` Junio C Hamano
2008-12-12 2:40 ` Daniel Barkalow
2008-12-12 3:12 ` Junio C Hamano
2008-12-12 3:36 ` Jeff King
2008-12-12 16:13 ` Nguyen Thai Ngoc Duy
2008-12-12 16:45 ` Johannes Sixt [this message]
2008-12-12 16:54 ` Nguyen Thai Ngoc Duy
2008-12-13 5:51 ` Junio C Hamano
2008-12-13 5:51 ` Junio C Hamano
2008-12-12 16:08 ` Nguyen Thai Ngoc Duy
2008-12-07 3:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4942952E.1060706@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).