[PATCH] gitk: Swap positions of 'next' and 'prev' buttons in the 'Find' section.

[PATCH] gitk: Swap positions of 'next' and 'prev' buttons in the 'Find' section.

[Johannes Sixt]

From: Johannes Sixt <j6t@kdbg.org>

The button order 'prev' left of 'next' feels more natural than the other
way round, in particular, compared to the order of the forward and backward
arrows that are in the line above.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 gitk-git/gitk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gitk-git/gitk b/gitk-git/gitk
index b63109b..1c8d98e 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2052,7 +2052,7 @@ proc makewindow {} {
     button .tf.lbar.fnext -text [mc "next"] -command {dofind 1 1}
     button .tf.lbar.fprev -text [mc "prev"] -command {dofind -1 1}
     label .tf.lbar.flab2 -text " [mc "commit"] "
-    pack .tf.lbar.flabel .tf.lbar.fnext .tf.lbar.fprev .tf.lbar.flab2 \
+    pack .tf.lbar.flabel .tf.lbar.fprev .tf.lbar.fnext .tf.lbar.flab2 \
 	-side left -fill y
     set gdttype [mc "containing:"]
     set gm [tk_optionMenu .tf.lbar.gdttype gdttype \
-- 
1.6.1.rc3.980.ga0bb

Re: [PATCH] gitk: Swap positions of 'next' and 'prev' buttons in the 'Find' section.

[Paul Mackerras]

Johannes Sixt writes:

> The button order 'prev' left of 'next' feels more natural than the other
> way round, in particular, compared to the order of the forward and backward
> arrows that are in the line above.

The next/prev labels are a bit awkward in any case, since "next" finds
an earlier commit - one further down the list, and "prev" finds a
later commit - one further back in the list.  A better solution might
be to make images for arrows pointing up and down and use compound
buttons so the buttons say Find ^ and Find v (if you image the ^/v as
up and down arrows).

I also find myself often wanting a "Find first" button, i.e. search
starting at the top of the list.

Paul.

[PATCH] gitk: Swap positions of 'next' and 'prev' buttons in the 'Find' section.

[Johannes Sixt]

The button order 'prev' left of 'next' feels more natural than the other
way round, in particular, compared to the order of the forward and backward
arrows that are in the line above.

Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
---
  gitk |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gitk b/gitk
index 01a8541..727f4a0 100755
--- a/gitk
+++ b/gitk
@@ -767,7 +767,7 @@ proc makewindow {} {
      button .tf.lbar.fnext -text "next" -command {dofind 1 1} -font uifont
      button .tf.lbar.fprev -text "prev" -command {dofind -1 1} -font uifont
      label .tf.lbar.flab2 -text " commit " -font uifont
-    pack .tf.lbar.flabel .tf.lbar.fnext .tf.lbar.fprev .tf.lbar.flab2 \
+    pack .tf.lbar.flabel .tf.lbar.fprev .tf.lbar.fnext .tf.lbar.flab2 \
  	-side left -fill y
      set gdttype "containing:"
      set gm [tk_optionMenu .tf.lbar.gdttype gdttype \
-- 
1.5.3.5.1298.g228d6-dirty