From: Nicolas Morey-Chaisemartin <devel@morey-chaisemartin.com>
To: "Pickens, James E" <james.e.pickens@intel.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [RFC PATCH 0/2] Add support for multi threaded checkout
Date: Thu, 18 Dec 2008 22:16:57 +0100 [thread overview]
Message-ID: <494ABDC9.9060001@morey-chaisemartin.com> (raw)
In-Reply-To: <3BA20DF9B35F384F8B7395B001EC3FB3265B2A01@azsmsx507.amr.corp.intel.com>
Pickens, James E a écrit :
> Even in that case it will have *some* impact
> from locking/unlocking the mutex, but I think it would be in the noise.
>
> James
> -
I guess you could do something like :
#define checkout_lock() core_threaded_checkout ?pthread_mutex_lock(&checkout_mutex) : (void) 0
#define checkout_unlock() core_threaded_checkout ?pthread_mutex_unlock(&checkout_mutex) : (void) 0
It should be faster when you don't actually use threaded checkouts, as you won't unnecessarily lock/unlock your mutex.
Have you looked at the perf from local to local? I'm just curious.
Nicolas Morey-Chaisemartin
next prev parent reply other threads:[~2008-12-18 21:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 20:51 [RFC PATCH 0/2] Add support for multi threaded checkout Pickens, James E
2008-12-18 20:56 ` [PATCH 1/2] " James Pickens
2008-12-18 20:56 ` [PATCH 2/2] Add core.threadedcheckout config option James Pickens
2008-12-18 21:41 ` [PATCH 1/2] Add support for multi threaded checkout Linus Torvalds
2008-12-18 23:35 ` James Pickens
2008-12-19 0:13 ` Linus Torvalds
2008-12-18 21:02 ` [RFC PATCH 0/2] " Nicolas Pitre
2008-12-18 21:13 ` James Pickens
2008-12-18 21:16 ` Nicolas Morey-Chaisemartin [this message]
2008-12-18 21:42 ` James Pickens
2008-12-19 1:04 ` James Pickens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494ABDC9.9060001@morey-chaisemartin.com \
--to=devel@morey-chaisemartin.com \
--cc=git@vger.kernel.org \
--cc=james.e.pickens@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).