From: Johannes Sixt <j.sixt@viscovery.net>
To: unlisted-recipients:; (no To-header on input)
Cc: Alexander Potashev <aspotashev@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] Use is_pseudo_dir_name everywhere
Date: Fri, 09 Jan 2009 08:22:30 +0100 [thread overview]
Message-ID: <4966FB36.2030409@viscovery.net> (raw)
In-Reply-To: <4966F6BB.90408@viscovery.net>
Johannes Sixt schrieb:
> Alexander Potashev schrieb:
>> - if ((ent->d_name[0] == '.') &&
>> - (ent->d_name[1] == 0 ||
>> - ((ent->d_name[1] == '.') && (ent->d_name[2] == 0))))
>> + if (is_pseudo_dir_name(ent->d_name))
>
> Nit-pick: When I read the resulting code, then I will have to look up that
> is_pseudo_dir_name() indeed only checks for "." and "..". But if it were
> named is_dot_or_dotdot(), then I would have to do that.
... then I would *not* have to do that, of course.
-- Hannes
next prev parent reply other threads:[~2009-01-09 7:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 23:24 [PATCH 0/2] Allow cloning to an existing empty directory Alexander Potashev
2009-01-08 23:24 ` [PATCH 1/2] " Alexander Potashev
2009-01-08 23:24 ` [PATCH 2/2] Use is_pseudo_dir_name everywhere Alexander Potashev
2009-01-09 7:03 ` Johannes Sixt
2009-01-09 7:22 ` Johannes Sixt [this message]
2009-01-09 8:33 ` Junio C Hamano
2009-01-09 10:24 ` Alexander Potashev
2009-01-10 2:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4966FB36.2030409@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=aspotashev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).