From: Ted Pavlic <ted@tedpavlic.com>
To: "Boyd Stephen Smith Jr." <bss@iguanasuicide.net>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] Update bash completions to prevent unbound variable errors.
Date: Mon, 12 Jan 2009 16:11:32 -0500 [thread overview]
Message-ID: <496BB204.2040109@tedpavlic.com> (raw)
In-Reply-To: <200901121435.35547.bss@iguanasuicide.net>
>> if [ -z "${1-}" ]
>
> That looks ugly to me. Any reason we shouldn't just "set +u" at the top of
> the script?
As already discussed, because the script must be sourced, then the "set
+u" has global scope.
I suppose that the option could be tested and then reset as appropriate
at the end of the script.
(note: for some reason Mercurial's bash completion script does not have
this problem; they use $1 directly without bash complaining)
--
Ted Pavlic <ted@tedpavlic.com>
Please visit my ALS association page:
http://web.alsa.org/goto/tedpavlic
My family appreciates your support in the fight to defeat ALS.
next prev parent reply other threads:[~2009-01-12 21:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 19:58 [PATCH] Update bash completions to prevent unbound variable errors Ted Pavlic
2009-01-12 20:35 ` Boyd Stephen Smith Jr.
2009-01-12 20:40 ` Adeodato Simó
2009-01-12 21:27 ` Boyd Stephen Smith Jr.
2009-01-12 21:31 ` Shawn O. Pearce
2009-01-12 21:38 ` Boyd Stephen Smith Jr.
2009-01-12 21:11 ` Ted Pavlic [this message]
2009-01-12 21:21 ` Ted Pavlic
2009-01-12 21:32 ` Shawn O. Pearce
2009-01-12 21:51 ` Ted Pavlic
2009-01-12 21:25 ` Adeodato Simó
2009-01-12 21:37 ` Ted Pavlic
2009-01-12 21:47 ` Adeodato Simó
2009-01-12 21:40 ` Adeodato Simó
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496BB204.2040109@tedpavlic.com \
--to=ted@tedpavlic.com \
--cc=bss@iguanasuicide.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).