From: Cesar Eduardo Barros <cesarb@cesarb.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Teach format-patch to handle output directory relative to cwd
Date: Mon, 12 Jan 2009 21:12:21 -0200 [thread overview]
Message-ID: <496BCE55.8030407@cesarb.net> (raw)
In-Reply-To: <7vab9wgmwe.fsf@gitster.siamese.dyndns.org>
Junio C Hamano escreveu:
> Without any explicit -o parameter, we correctly avoided putting the
> resulting patch output to the toplevel. We should do the same when
> the user gave a relative pathname to be consistent with this case and also
> with how other commands handle relative pathnames.
Works great, only the resulting output to the screen is a bit
ugly/confusing:
drivers/net/../../../0001-sc92031-more-useful-banner-in-kernel-log.patch
drivers/net/../../../0002-sc92031-remove-meaningless-version-string.patch
drivers/net/../../../0003-sc92031-inline-SC92031_DESCRIPTION.patch
drivers/net/../../../0004-sc92031-use-device-id-directly-instead-of-made-up-n.patch
drivers/net/../../../0005-sc92031-add-a-link-to-the-datasheet.patch
I would expect:
../../../0001-sc92031-more-useful-banner-in-kernel-log.patch
../../../0002-sc92031-remove-meaningless-version-string.patch
../../../0003-sc92031-inline-SC92031_DESCRIPTION.patch
../../../0004-sc92031-use-device-id-directly-instead-of-made-up-n.patch
../../../0005-sc92031-add-a-link-to-the-datasheet.patch
(after all, I am still inside the drivers/net directory)
--
Cesar Eduardo Barros
cesarb@cesarb.net
cesar.barros@gmail.com
next prev parent reply other threads:[~2009-01-12 23:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 22:04 git-format-patch with -o ../ in subdir of working copy writes output in wrong place Cesar Eduardo Barros
2009-01-12 22:49 ` [PATCH] Teach format-patch to handle output directory relative to cwd Junio C Hamano
2009-01-12 23:12 ` Cesar Eduardo Barros [this message]
2009-01-13 1:00 ` Junio C Hamano
2009-01-13 9:24 ` Cesar Eduardo Barros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496BCE55.8030407@cesarb.net \
--to=cesarb@cesarb.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).