git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael J Gruber <git@drmicha.warpmail.net>
To: "Adeodato Simó" <dato@net.com.org.es>
Cc: Craig Fratrik <cfratrik@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Noted that vi is the final choice of editor in git   help commit
Date: Wed, 14 Jan 2009 12:14:26 +0100	[thread overview]
Message-ID: <496DC912.1070908@drmicha.warpmail.net> (raw)
In-Reply-To: <20090114095512.GA29927@chistera.yi.org>

Adeodato Simó venit, vidit, dixit 14.01.2009 10:55:
> * Craig Fratrik [Tue, 13 Jan 2009 14:33:36 -0800]:
> 
>>  The editor used to edit the commit log message will be chosen from the
>>  GIT_EDITOR environment variable, the core.editor configuration variable, the
>> -VISUAL environment variable, or the EDITOR environment variable (in that
>> -order).
>> +VISUAL environment variable, the EDITOR environment variable, or finally 'vi'
>> +(in that order).
> 
> May I suggest:
> 
>    The editor used to edit the commit log message will be chosen from the
>    GIT_EDITOR environment variable, the core.editor configuration variable, the
>    VISUAL environment variable, or the EDITOR environment variable (in that
>   -order).
>   +order). If none of those are set, "vi" will be used.
> 

+order). If none of those are set, "vi" will be used unless TERM is
+unset or set to "dumb".

There is also some special parsing of the value but I don't think it
needs to be advertised. The terminal-less case, on the other hand, may
be relevant for scripters and ssh'ers.

Cheers,
Michael

      reply	other threads:[~2009-01-14 11:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-13 22:33 [PATCH] Noted that vi is the final choice of editor in git help commit Craig Fratrik
2009-01-14  9:55 ` Adeodato Simó
2009-01-14 11:14   ` Michael J Gruber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496DC912.1070908@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=cfratrik@gmail.com \
    --cc=dato@net.com.org.es \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).