From: Johannes Sixt <j.sixt@viscovery.net>
To: Jeff King <peff@peff.net>
Cc: "Tor Arne Vestbø" <tavestbo@trolltech.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH next v2] git-notes: add test case for multi-line notes
Date: Wed, 14 Jan 2009 18:14:31 +0100 [thread overview]
Message-ID: <496E1D77.6000307@viscovery.net> (raw)
In-Reply-To: <20090114165633.GC15758@coredump.intra.peff.net>
Jeff King schrieb:
> On Wed, Jan 14, 2009 at 05:28:11PM +0100, Tor Arne Vestbø wrote:
>
>> +MSG=${MSG//%/}
>> +printf "$MSG" > "$1"
>> +printf "$MSG" >& 2
>
> Substitution parameter expansion is a bash-ism, IIRC. How about just
>
> printf %s "$MSG" ?
A the point was that $MSG contains \n, which should be turned int LF. IMO,
the easiest way to achieve this is:
MSG='b3
c3c3c3c3
d3d3d3'
test_expect_success ' ... ' '
...
MSG="$MSG" git notes edit
'
and go back to using echo in the part cited above.
-- Hannes
next prev parent reply other threads:[~2009-01-14 17:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 19:57 [PATCH next] git-notes: fix printing of multi-line notes Tor Arne Vestbø
2009-01-13 22:40 ` Johannes Schindelin
2009-01-14 6:48 ` Junio C Hamano
2009-01-14 10:14 ` Johannes Schindelin
2009-01-14 14:39 ` [PATCH next] git-notes: add test case for " Tor Arne Vestbø
2009-01-14 15:34 ` Johannes Schindelin
2009-01-14 16:28 ` [PATCH next v2] " Tor Arne Vestbø
2009-01-14 16:56 ` Jeff King
2009-01-14 17:09 ` Boyd Stephen Smith Jr.
2009-01-14 17:13 ` Jeff King
2009-01-14 17:14 ` Johannes Sixt [this message]
2009-01-14 17:19 ` Jeff King
2009-01-14 18:01 ` Johannes Schindelin
2009-01-14 20:57 ` [PATCH next v3] " Tor Arne Vestbø
2009-01-14 21:10 ` Johannes Schindelin
2009-01-16 13:06 ` [PATCH next v4] git-notes: fix printing of " Tor Arne Vestbø
2009-01-18 21:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496E1D77.6000307@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=tavestbo@trolltech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).