From: public_vi <public_vi@tut.by>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, normalperson@yhbt.net
Subject: Re: [PATCH] git-svn: add --ignore-paths option for fetching
Date: Sun, 25 Jan 2009 18:29:08 +0200 [thread overview]
Message-ID: <497C9354.5050902@tut.by> (raw)
In-Reply-To: <200901251521.15591.trast@student.ethz.ch>
It is useful for me, but I think I can be useful for others too.
May be it's better to make in inclusive, i.e. "--only-matching=<regex>"?
> This would be a good place to explain why this is useful, and (if
> applicable) why you chose to implement it the way you did.
>
OK, fixing them.
> You put the --ignore-paths explanation in the middle of the
> --localtime documentation (the last paragraph quoted still talks about
> --localtime).
>
> This is the first function in git-svn.perl using camelCase. Consider
> sticking to the current style and spelling it is_path_ignored().
>
> You broke the symmetry here, while all other hunks just add an
> equivalent check to the existing in_dot_git().
>
> However, the latter makes me wonder if it would be cleaner to move the
> in_dot_git() test to isPathIgnored (er, is_path_ignored) too?
>
next prev parent reply other threads:[~2009-01-25 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-25 6:27 [PATCH] git-svn: add --ignore-paths option for fetching Vitaly "_Vi" Shukela
2009-01-25 14:21 ` Thomas Rast
2009-01-25 16:29 ` public_vi [this message]
2009-01-25 22:42 ` Eric Wong
2009-01-25 22:48 ` public_vi
2009-01-26 1:18 ` Eric Wong
2009-01-26 6:28 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2009-01-25 22:21 Vitaly "_Vi" Shukela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497C9354.5050902@tut.by \
--to=public_vi@tut.by \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).